X-Sylpheed-Account-Id:1
S:andy.sharp@onstor.com
SCF:#mh/Mailbox/sent
X-Sylpheed-Sign:0
X-Sylpheed-Encrypt:0
X-Sylpheed-Privacy-System:
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09FCEBD1@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 14 May 2008 17:21:41 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20080514172141.646ea959@ripper.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E09FCEBD1@onstor-exch02.onstor.net>
Organization: Onstor
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 14 May 2008 15:54:30 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Change 29231 by maximk@maximk-13 on 2008/05/14 15:49:30 *pending*
> 
>         Make mgmtbus look more like ethernet device so the network
> traces
>            look nicer.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c#
> 12 edit

Tell me more about the following:

What bug is this for?  I'm wary of unnecessary kernel changes at this
point, especially because I'm in the middle of trying to debug a
problem in this driver, and this change might skew the error
characteristics.

You're change adds to the size of mgmtbus packets, adds to the
processing done at interrupt time, and changes the arp type to be
ether, all of which I think are reasons to pause for thought.  Does
this mean that ARP broadcasts will get sent to the mgmtbus interface?
Will DHCP try to send broadcasts on the interface?

What does this do that is helpful?  Your comment says "...network
traces look nicer."  Nicer how?  Is it a big enough advantage in your
work that we should take the risk?  Can we now use ethereal on mgmtbus
interface?  Do we already?