X-Sylpheed-Account-Id:1
S:andy.sharp@onstor.com
SCF:#mh/Mailbox/sent
X-Sylpheed-Sign:0
X-Sylpheed-Encrypt:0
X-Sylpheed-Privacy-System:
RMID:#mh/Mailbox/perfarce	0	WEBMAILD3yiYvx0X62k00002615@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 27 May 2008 18:01:51 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Jonathan Goldick <jonathan.goldick@onstor.com>
Subject: Re: PERFORCE change 29429 for review
Message-ID: <20080527180151.5ecbd629@ripper.onstor.net>
References: <WEBMAILD3yiYvx0X62k00002615@mail.onstor.com>
Organization: Onstor
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Jon,

I really have to ask you to be tougher on your code reviews of Max.
This is just one of many that you review for him where glaring
deficiencies glide through your review.  The two things that hit me
immediately are there are zero (0) comments to go along with all the
new code, nevermind all the code changes; and a stinking bug number and
one brief line in the checkin comment.  The checkin comment should have
had a lot more description about what the changes were and how they
worked, and/or there should have been a lot of comments describing the
new functions and how they worked and what they are for, etc.  As well
as the changes.

He's always going to be "dangerous" as long as you continue to let him
get away with this kind of undisciplined behavior.

a


On 27 May 2008 14:25:01 -0700 Maxim Kozlovsky
<maxim.kozlovsky@onstor.com> wrote:

> Change 29429 by maximk@maximk-13 on 2008/05/27 14:23:55
> 
> 	23879. Implement hardware checksum offloading for TCP.
> 	       Reviewed by jong.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-dcache/dcache-api.c#40 edit
> ... //depot/dev/nfx-tree/code/sm-dcache/dcache-util.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-dp-proxy/dp-proxy.c#10 edit
> ... //depot/dev/nfx-tree/code/sm-eee/eee-poll.c#6 edit
> ... //depot/dev/nfx-tree/code/sm-luc/luc-init.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-luc/luc-reas.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-luc/luc-tx.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-luc/luc.h#3 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250-dm/sb1250-dm-api.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250-dm/sb1250-dm-mov.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250-dm/sb1250-dm.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250-dm/sb1250-dm.h#3 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/29429?ac=10
