X-Sylpheed-Account-Id:2
S:andy.sharp@lsi.com
SCF:#mh/Mailbox/sent
X-Sylpheed-Sign:0
X-Sylpheed-Encrypt:0
X-Sylpheed-Privacy-System:
RMID:#imap/LSI/INBOX	0	4AE24B70.5010008@lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 23 Oct 2009 19:58:40 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: William Fisher <bill.fisher@lsi.com>
Cc: "Stark, Brian" <Brian.Stark@lsi.com>
Subject: Re: please review 33334
Message-ID: <20091023195840.5cfeb5ec@ripper.onstor.net>
References: <20091022172108.51f46b80@ripper.onstor.net>
	<4AE24B70.5010008@lsi.com>
Organization: LSI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Bill,

I'm really sick of your assinine attitude.  Start showing me the
proper respect or it's going to come back and bite you, hard.  It's not
your place to dain to tell me what the proper use of my time is.  It's
my job to tell you what the proper use of your time is.

This is supposed to be a code review.  That means you're supposed to
tell me where the change needs to be modified.  Not to try to show the
world how smart you are by ranting absurd criticisms.  You should know
that considering you're supposed to be a senior engineer.  You're just
making yourself look like an idiot.

If you can control your frightened "criticize what intimidates me"
reaction, you might study some of these changes to improve your own
coding skills.  The very things you criticize in here are the mirror
image of the things you criticize, practically daily, about eee code.

And lastly, consider that you're acting exactly like Max when someone
touches "his" code.  Another thing you criticize almost daily.


On Fri, 23 Oct 2009 18:33:52 -0600 William Fisher <bill.fisher@lsi.com>
wrote:

> Andrew Sharp wrote:
> > Hi guys,
> > 
> > Larry need only look at the makefile changes.
> > 
> > The tuxstor build doesn't quite work because I need to follow up
> > this changelist with another one to fix the TUXRX references the
> > newly created tuxstor files.
> > 
> > Change 33334 by andys@ripper on 2009/09/14 17:48:04 *pending*
> > 
> > 	Changes for switching to new tuxstor project from old tuxrx
> > 	project.
> > 
> > 	Minor cleanup of linux/Makefile and linux/kernel/Makefile.
> > 
> > 	Add external symbol declarations for small number of symbols
> > 	needed by the acpu module.
> > 
> > 	Clean up comments and some of the macros in mgmtbus driver
> > code, plus reorganize some of the code to eliminate large ifdef
> > blocks and other infelicities.  Bring the recent changes to the code
> > 	in the dev tree over as well.
> > 
> > 	Move linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx
> > 	to ...tuxstor.
> > 
> > 	Micro cleanup of the mgmtbus-aware code in sb1250-mac.c
> > (sibyte ethernet driver).
> > 
> > 	reviewed by
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/linux/Makefile#1 edit
> > ... //depot/tuxrx/linux/kernel/Makefile#2 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/HEAD#1 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/refs/heads/onstor-2.6.22#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Makefile#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/head.S#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/stacktrace.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/common/ons_crashdump.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/dbg_io.c#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/setup.c#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/Makefile#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/dbg_io.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/prom.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/setup.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/time.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/Makefile#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxrx.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxstor.c#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-config#4
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-debug-config#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Kconfig#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Makefile#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/cougar_mgmt_bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/tuxrx_mgmt_bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/bootinfo.h#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/cpu-feature-overrides.h#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/tuxstor.h#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/ons_crashdump.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/slab_def.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/net/sock.h#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/stacktrace.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time/timekeeping.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Makefile#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Kconfig#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Makefile#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/acpu.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-config#2
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-debug-config#2
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-debug-config#1
> > branch ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#3 edit
> > 
> 
> I have gone through about 60% of the files.
> 
> I can't believe that you have spent so much time reworking
> the comment layout in the header files, doing useless
> renaming of ONSTOR_TUXRX to ONSTOR_TUXSTOR in the Kconfig
> for virtually no purpose except to satifsy your belief
> that the TXRX name should now be TUXSTOR!
> 
> This is completely wasted effort particularly since
> we are behind schedule and this adds NO new features
> to get us moving forward.
> 
> You have stripped off the /* CONFIG_XXX */ lines
> off the #endif's statements for some reason and
> you are inconsistent with those changes throughout
> the code. Some places you have ripped them
> off and others they escaped your edits.
> 
> You have now made the mgmt_bus.h header file now nearly unreadable
> IMHO. You have added huge amount of white space for no particularly
> good reason, by stripping off comments at the end of lines
> and added new lines containing the comments. What for?
> Editorial perspective?
> 
> The acpu.c file you now have ifdef'ed out the code that
> makes the current rcon-shell and polling loop to
> work by adding a "ifdef 0" comment with an
> additional comment, "To be resolved later".
> 
> Thanks, that just means I have to revert the file to
> add them back until the rcon shell is made
> more modular, until then we are broken if this
> change goes in.
> 
> Obviously you have not run any of the rcon shell
> commands, the polling loop code nor any of the
> EEE packet forwarding tests on this code as
> all of them will be broken. How is that forward
> progesss?
> 
> You have moved large chucks of the mgmtbus
> initialization code to a separate file
> since that is somehow "cleaner" than what
> was there, with an ifdef.
> 
> The half-life of this driver going forward
> will probably be short since x86 is on the
> horizon and all of the mgmtbus, rcon drivers
> and the cougar platform specific code is
> not going forward.
> 
> I don't have the time to provide comments on
> all of the diff's
> on each of the times but 90+% of these
> changes are not needed NOR required.
> 
> What specific bugs are these fixes addressing?
> 
> Converting the ONSTOR_TUXRX to ONSTOR_TUXSTOR
> config variables is make-work. I can't believe
> you spent time editing those changes.
> 
> It should be LSI_XXX since ONSTOR no
> longer exists, if you want to be
> specific.
> 
> There are a few cleanups on the architecture
> specific portions of the driver code that are nice
> but not worth spending time on, right now.
> 
> These changes are NOT even identified in the
> development schedule as something critical.
> The ones we called out were, getting a set
> of PROM for booting, now not needed, getting
> an 8-way kernel running, the remote 1480
> PCI device driver identification for the FC
> device, etc.
> 
> The critical bug fix was the ETHERNET MAC
> address not being unique since we were not
> getting the correct bottoom bits.
> I found that bug weeks ago and Rendell did
> the fix several weeks ago.
> 
> Hence, in summary, the changes to the
> mgmtbus driver, rcon driver, trivial
> CONFIG variable renames and the acpu changes
> and wholesale changes to huge comment blocks
> are NOT required.
> 
> This change set should be cut down by at least 85%
> by removing those changes. The gratuious changes
> to the comments and endif's are another
> set of changes that reduce readability IMHO,
> when you have nested ifdef's in the code.
> 
> This change set needs rework.
> 
> Later,
> 
> -- Bill
> 
> 
> 
> 
> 
