X-Sylpheed-Account-Id:2
S:andy.sharp@lsi.com
SCF:#mh/Mailbox/sent
X-Sylpheed-Sign:0
X-Sylpheed-Encrypt:0
X-Sylpheed-Privacy-System:
RMID:#imap/LSI/INBOX	0	4AE84E62.2050404@lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 28 Oct 2009 12:20:28 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Fisher, Bill" <Bill.Fisher@lsi.com>
Cc: Brian Stark <brian.stark@lsi.com>, "Stark, Brian" <Brian.Stark@lsi.com>
Subject: Re: please review 33334
Message-ID: <20091028122028.6c795298@ripper.onstor.net>
References: <20091022172108.51f46b80@ripper.onstor.net>
	<4AE84E62.2050404@lsi.com>
Organization: LSI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hilarious.

My problem, Bill, is that you are not in the position to dictate to me
how to best spend my time, nor did you properly review the code.  I
sent it to you to try and teach you how a proper changelist looks, how
it is to be reviewed and like that.  All you could think to do is whine
and bitch about someone touching your code.  Worse than Max, by far.

The mgmtbus code was done 7 months ago, and I sent it to you for
review at that time as well.  You said it was fine but I'm quite sure
you never took the time to even look at it.  The rest of the are quite
necessary and I'm sad that you aren't able to recognize what makes a
project and what is just a crappy last dash hack.  The stuff this
change takes care of is *exactly* the kind of thing you criticize the
eee code for not ever cleaning up.

I wish that you had been working on the code as much as I have, or even
half as much.  Maybe then the networking code would have been done
months ago and many other tasks would also be done.

Just in case you're thinking of your typical blowing-up-distraction
manuever at this point, know that I'm not to be trifled with nor am I
ignorant of what effort is needed to produce what output.  I know
*exactly* what effort has been put in and what hasn't. When you start
putting in the kind of effort this project needs, you will start
producing commesurately, and then I will gladly let you rip me all you
want.  Until then you're just a do-nothing blow hard who is in the way.
That's something that I can't tolerate at this stage, and shouldn't
have ever tolerated at all, but there were several mitigating factors
at the time.  Those factors are history, and so is anyone who is making
a roadblock out of themselves.

On Wed, 28 Oct 2009 08:00:02 -0600 William Fisher <bill.fisher@lsi.com>
wrote:

> Andrew Sharp wrote:
> > Hi guys,
> >
> > Larry need only look at the makefile changes.
> >
> > The tuxstor build doesn't quite work because I need to follow up
> > this changelist with another one to fix the TUXRX references the
> > newly created tuxstor files.
> >
> > Change 33334 by andys@ripper on 2009/09/14 17:48:04 *pending*
> >
> > 	Changes for switching to new tuxstor project from old tuxrx
> > 	project.
> >
> > 	Minor cleanup of linux/Makefile and linux/kernel/Makefile.
> >
> > 	Add external symbol declarations for small number of symbols
> > 	needed by the acpu module.
> >
> > 	Clean up comments and some of the macros in mgmtbus driver
> > code, plus reorganize some of the code to eliminate large ifdef
> > blocks and other infelicities.  Bring the recent changes to the code
> > 	in the dev tree over as well.
> >
> > 	Move linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx
> > 	to ...tuxstor.
> >
> > 	Micro cleanup of the mgmtbus-aware code in sb1250-mac.c
> > (sibyte ethernet driver).
> >
> > 	reviewed by
> >
> > Affected files ...
> >
> > ... //depot/tuxrx/linux/Makefile#1 edit
> > ... //depot/tuxrx/linux/kernel/Makefile#2 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/HEAD#1 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/refs/heads/onstor-2.6.22#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Makefile#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/head.S#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/stacktrace.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/common/ons_crashdump.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/dbg_io.c#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/setup.c#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/Makefile#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/dbg_io.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/prom.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/setup.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/time.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/Makefile#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxrx.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxstor.c#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-config#4
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-debug-config#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Kconfig#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Makefile#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/cougar_mgmt_bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/tuxrx_mgmt_bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/bootinfo.h#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/cpu-feature-overrides.h#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/tuxstor.h#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/ons_crashdump.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/slab_def.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/net/sock.h#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/stacktrace.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time/timekeeping.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Makefile#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Kconfig#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Makefile#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/acpu.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-config#2
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-debug-config#2
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-debug-config#1
> > branch ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#3 edit
> >
> >   
> I apologize for ripping you a new one with respect to these changes.
> 
> Since you and I have been working on the code for almost a year,
> I feel strongly about how the schedule is slipping and we
> are not finishing the items we "promised" Brian when
> we created the group schedule. Hopefully going
> forward, we can recover some ground with better
> coordination/communication of the things we are
> all working on.
> 
> I still feel this fix is not really required, and the least should
> bereworked to not edit comments in the headers
> and other code file; Just change the minimum
> number of files to effect your intent.
> 
> Leave the acpu code as it today, since I have the
> tpl and neteee2 files ready for examination upon
> our return froim Kansas. These changes get the
> old rcon shell ack to working and require
> the old acpu.c file. In addition, it moves
> the kernel header files to the include/linux/onstor
> directories.
> 
> I will rework the txrx module next to use
> these header files next wee. Hence this
> is a two step scheme.
> 
> I will also get the "module" to load
> next week along with resolving the
> EXPORT_SYMBOL(XXX)
> directives in the kernel tpl and
> neteee2 module.
> 
> Later,
> 
> -- Bill
> 
> 
> 
