X-Sylpheed-Account-Id:2
S:andy.sharp@lsi.com
SCF:#mh/Mailbox/sent
X-Sylpheed-Sign:0
X-Sylpheed-Encrypt:0
X-Sylpheed-Privacy-System:
RMID:#mh/Mailbox/perfarce	0	WEBMAILNuCLWNLJvKQJ00113b37@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 2 Feb 2010 17:51:53 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <rendell.fong@lsi.com>
Cc: Maxim Kozlovsky <maxim.kozlovsky@lsi.com>, Bill Fisher
 <bill.fisher@lsi.com>
Subject: Re: PERFORCE change 34347 for review
Message-ID: <20100202175153.74fef36f@ripper.onstor.net>
References: <WEBMAILNuCLWNLJvKQJ00113b37@mail.onstor.com>
Organization: LSI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 2 Feb 2010 17:20:01 -0700 Rendell Fong <rendell.fong@lsi.com>
wrote:

> Change 34347 by rendellf@rendellf-test on 2010/02/02 16:15:47
> 
> 	Restructured elog code to build kernel module for tuxstor.
> 	Reviewed by: MaximK
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#7 edit
> ... //depot/tuxrx/nfx-tree/code/sm-elog/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-elog/elog-api.h#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-elog/elog-def.h#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-elog/elog-embedded.c#5 edit

elog-api.h, line 166

Goddamnit, I spent a lot of time figuring out how to, and doing, making
this flexible and nice.  Can we please not revert to the 70's user
application notation of "../foo/foo.h"?  Especially in a header file.

I'm sorry, but this would seem to be a complete waste of time.  This
elog_embedded is dead code.  We're not keeping eee protocol based elog
message passing in tuxstor.  We're trying to get rid of the eee
protocol, not preserve it.  Orion will not have anything but TCP/IP.
elog in the kernel should be little more than a call to printk with the
right facility attached. syslog will handle the messages from there.

Who is going to call elog_receiveEEEMessage()?  Not anywhere in the
tuxstor or ssc kernel.