X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7A317.9BFC08DD@onstor-exch02.onstor.net>; Wed, 30 May 2007 17:06:59 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: review cw_install changes
Date: Wed, 30 May 2007 17:06:59 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E022157FE@onstor-exch02.onstor.net>
In-Reply-To: <20070529152924.7a3af58e@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: review cw_install changes
Thread-Index: AceiQM89qx4TGtYNQIWLndToUxYNGAAoj9OA
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Makefile comments:
Write cw_install.sh to $(PATH_TO_RELEASE)/etc .vs Tools. Don't pollute
source trees with derived objects. Then you don't need the move.

Line 562: Looking at how N_VERS is used in cw_install, you should use
the make macro $(VER) which is the contents of nfx-tree/Tools/version.
It doesn't have the 'b' character appended to it. So it will just be
3.0.0.0 or 2.2.3.0, etc. The version file in the release directory has a
character 'b' appended to it to differentiate between bobcat and
cheetah. (Cheetah's version file does not have the 'b'. I have no idea
what it will be for cougar and bobcat linux.

Cw_install.in comments:
Line 106: hw_initials for Bobcat Linux will most likely be 'BL'

Line: 582: Missing preposition before "most cases." Perhaps is should be
"in most cases." Or "for most cases."  (Whatever is your preferences (or
most gooder English.)

Line 596-597: Maybe it should say: "After a successful upgrade, your
system will boot the software and you will have to log in again."
Or it could be "When efficacious upgradation consummated system reboot
will occur, necessitating login procedures upon completion of init level
two."

Line 640: htype=3D`hw_initials` I think you meant hwtype=3D`hw_initials`
because htype is unused.

Lines 644-653: Unless you change the Makefile as mentioned above you
can't use $N_VERS unmodified for anything but Cheetah builds. For bobcat
(BSD) N_VERS would be set to 3.0.0.0b which breaks all of your default
URLs.

The functional specification for the CW installation procedure has a
requirement that the script "verifies the integrity of the copied files"
(Pg. 9 of 14) and "verify the install before performing the reboot of
the installed release." (Pg. 6 of 14) I did not see where the script did
this.

Changes to flash_install.sh can go with this change list or a separate
one. It does make sense to check the file in with this change list.

Verify_install.sh can go with this change, but I think a bug should be
opened and filed for this fix and add this fix the Delorean release. It
definitely should be back-ported to 2.2.3.0. Assigning a defect to it
would expedite the process. (I would hope anyway.) Brian De Forest
should be made aware of this fix.

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, May 29, 2007 3:29 PM
To: Larry Scheer
Subject: review cw_install changes

Hi Larry,

Here is an initial cut at the cw_install checkin.  The files besides
cw_install.in need to go into released Delorean, cw_install.in itself
does not.

I made slight changes to verify_install.sh which strictly aren't
necessary, but are related to fixing the reboot problem which, contrary
to popular belief, happens both on cheetahs and bobcats.  nicing down
the tar (and the gzip sub process) seems to alleviate the loading
problem allowing other programs enough scheduling time to keep things
from rebooting.  Unfortunately, it would really have to be applied to
2.2 and 1.3.3 in order to help them.  Maybe it could go into 2.2.3?

The nfx-tree/Makefile changes are to support the converting of
cw_install.in to a shell script and inserting dynamic values into that
script at build time.

The rc change is to make the motd magic work.

Let me know what you think.

Thanks,

a




Change 24125 by andys@ripper on 2007/05/29 09:59:49 *pending*

        Install script and related changes for standalone install
program.

Affected files ...

... //depot/FB-DELOREAN/nfx-tree/Makefile#9 edit
... //depot/FB-DELOREAN/nfx-tree/Tools/cw_install.in#1 add
... //depot/FB-DELOREAN/nfx-tree/Tools/flash_install.sh#6 edit
... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/verify_install.sh#13
edit
... //depot/FB-DELOREAN/openbsd/src/etc/rc#6 edit
