X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C79D63.9C600506@onstor-exch02.onstor.net>; Wed, 23 May 2007 10:55:55 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C79D63.9C600506"
References: <BB375AF679D4A34E9CA8DFA650E2B04E03CC1437@onstor-exch02.onstor.net><20070523101851.001cdfb9@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E03CC1439@onstor-exch02.onstor.net> <20070523104919.0171ea22@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: please review code change
Date: Wed, 23 May 2007 10:55:09 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E03CC143A@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review code change
Thread-Index: AcedYrAwKTdfJPuNSqmo6asDxUD9UwAANC6p
From: "Ed Kwan" <ed.kwan@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C79D63.9C600506
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

I see.
Change number is 24062.
=20
Thanks,
Ed

________________________________

From: Andy Sharp
Sent: Wed 5/23/2007 10:49 AM
To: Ed Kwan
Subject: Re: please review code change



Use "p4 change" just like "p4 submit", except that it doesn't submit
the change, it only puts it in a numbered changelist, rather than in
"default" changelist.  Later you can submit it with "p4 submit -c <cl#>"

On Wed, 23 May 2007 10:44:39 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> Hi Andy,
>=20
> The client name is: edk-r220rel
> I don't have a change #.  I thought I need the code reviewed before I
> can "p4 submit"?
> Thanks,
> Ed
>
> ________________________________
>
> From: Andy Sharp
> Sent: Wed 5/23/2007 10:18 AM
> To: Ed Kwan
> Subject: Re: please review code change
>
>
>
> Hi Ed,
>
> Can you give me a changelist #, and a p4 client name?  As long as the
> client root is on mightydog, I feed that into my review script and it
> takes care of everything for me.
>
> Thanks,
>
> a
>
> On Tue, 22 May 2007 18:14:48 -0700 "Ed Kwan" <ed.kwan@onstor.com>
> wrote:
>
> > Hi Andy,
> >
> > This is for TED 19137.
> > Client root: /homes/edk/p4/r220rel
> > File: openbsd/src/lib/readline-4.1/signals.c
> >
> > The change comes from readline version 5.2 (attached).  Actually,
> > there's minor bug in this new signals.c, line 303, which is the same
> > as line 302.
> >
> > Thanks,
> > Ed
>
>



------_=_NextPart_001_01C79D63.9C600506
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<HTML dir=3Dltr><HEAD><TITLE>Re: please review code change</TITLE>=0A=
<META http-equiv=3DContent-Type content=3D"text/html; charset=3Dunicode">=0A=
<META content=3D"MSHTML 6.00.6000.16441" name=3DGENERATOR></HEAD>=0A=
<BODY>=0A=
<DIV id=3DidOWAReplyText57297 dir=3Dltr>=0A=
<DIV dir=3Dltr><FONT face=3DArial color=3D#000000 size=3D2>I =
see.</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>Change number is =
24062.</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>Thanks,</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>Ed</FONT></DIV></DIV>=0A=
<DIV dir=3Dltr><BR>=0A=
<HR tabIndex=3D-1>=0A=
<FONT face=3DTahoma size=3D2><B>From:</B> Andy Sharp<BR><B>Sent:</B> Wed =
5/23/2007 10:49 AM<BR><B>To:</B> Ed Kwan<BR><B>Subject:</B> Re: please =
review code change<BR></FONT><BR></DIV>=0A=
<DIV>=0A=
<P><FONT size=3D2>Use "p4 change" just like "p4 submit", except that it =
doesn't submit<BR>the change, it only puts it in a numbered changelist, =
rather than in<BR>"default" changelist.&nbsp; Later you can submit it =
with "p4 submit -c &lt;cl#&gt;"<BR><BR>On Wed, 23 May 2007 10:44:39 =
-0700 "Ed Kwan" &lt;ed.kwan@onstor.com&gt; wrote:<BR><BR>&gt; Hi =
Andy,<BR>&gt;&nbsp;<BR>&gt; The client name is: edk-r220rel<BR>&gt; I =
don't have a change #.&nbsp; I thought I need the code reviewed before =
I<BR>&gt; can "p4 submit"?<BR>&gt; Thanks,<BR>&gt; Ed<BR>&gt;<BR>&gt; =
________________________________<BR>&gt;<BR>&gt; From: Andy =
Sharp<BR>&gt; Sent: Wed 5/23/2007 10:18 AM<BR>&gt; To: Ed Kwan<BR>&gt; =
Subject: Re: please review code change<BR>&gt;<BR>&gt;<BR>&gt;<BR>&gt; =
Hi Ed,<BR>&gt;<BR>&gt; Can you give me a changelist #, and a p4 client =
name?&nbsp; As long as the<BR>&gt; client root is on mightydog, I feed =
that into my review script and it<BR>&gt; takes care of everything for =
me.<BR>&gt;<BR>&gt; Thanks,<BR>&gt;<BR>&gt; a<BR>&gt;<BR>&gt; On Tue, 22 =
May 2007 18:14:48 -0700 "Ed Kwan" &lt;ed.kwan@onstor.com&gt;<BR>&gt; =
wrote:<BR>&gt;<BR>&gt; &gt; Hi Andy,<BR>&gt; &gt;<BR>&gt; &gt; This is =
for TED 19137.<BR>&gt; &gt; Client root: /homes/edk/p4/r220rel<BR>&gt; =
&gt; File: openbsd/src/lib/readline-4.1/signals.c<BR>&gt; &gt;<BR>&gt; =
&gt; The change comes from readline version 5.2 (attached).&nbsp; =
Actually,<BR>&gt; &gt; there's minor bug in this new signals.c, line =
303, which is the same<BR>&gt; &gt; as line 302.<BR>&gt; &gt;<BR>&gt; =
&gt; Thanks,<BR>&gt; &gt; =
Ed<BR>&gt;<BR>&gt;<BR></FONT></P></DIV></BODY></HTML>
------_=_NextPart_001_01C79D63.9C600506--
