X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C79917.1D6B5102@onstor-exch02.onstor.net>; Thu, 17 May 2007 23:38:16 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C79917.1D6B5102"
References: <BB375AF679D4A34E9CA8DFA650E2B04E031D885E@onstor-exch02.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: neteee files integrated with the kernel
Date: Thu, 17 May 2007 23:36:19 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E1049BA@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: neteee files integrated with the kernel
Thread-Index: AceY/UfekI6Ut9TXT+eaTbhz3SHWqgAGZAbW
From: "Tim Gardner" <tim.gardner@onstor.com>
To: "Richard Beck" <IMCEAEX-_O=ONSTOR_OU=FIRST+20ADMINISTRATIVE+20GROUP_CN=RECIPIENTS_CN=RICHARD+2EBECK@onstor.com>,
	"Larry Scheer" <larry.scheer@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C79917.1D6B5102
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Prior to submitting any code it must go thru code review.
Please ask Andy to review the neteee changes.=20
Either Andy or I will review the mgmtbus changes.
After the review has been completed you can run the submit.
The p4 change description must have a line such as:
  reviewed by andys
=20
The lack of this line is causing your checkin to fail.
=20
Tim
=20

________________________________

From: Richard Beck
Sent: Thu 5/17/2007 8:33 PM
To: Larry Scheer; Andy Sharp
Cc: Tim Gardner
Subject: neteee files integrated with the kernel



The initial checkin of the neteee files is in changelists 24011 and =
24012.

Perforce seems a bit quirky, but then I'm not very familiar with it.

Any suggestions on the following errors?:

?1.=20

p4 submit -i

Submit validation failed -- fix problems then use 'p4 submit -c 24011'.=20

Submit check 'Reviewed_By_Field_Not_Self2' failed: no error message

2.=20

p4 submit -c 24011

Change 24011 belongs to user richardb.

bash-3.00$ whoami

richardb

1.      Is there a review process that is part of checkin with Perforce? =
=20
2.      Makes no sense.=20

I'm sure we'll get this resolved tomorrow.

Regards,

Rich



------_=_NextPart_001_01C79917.1D6B5102
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<HTML dir=3Dltr><HEAD><TITLE>neteee files integrated with the =
kernel</TITLE>=0A=
<META http-equiv=3DContent-Type content=3D"text/html; charset=3Dunicode">=0A=
<META content=3D"MSHTML 6.00.2800.1479" name=3DGENERATOR></HEAD>=0A=
<BODY>=0A=
<DIV id=3DidOWAReplyText19859 dir=3Dltr>=0A=
<DIV dir=3Dltr><FONT face=3DArial color=3D#000000 size=3D2>Prior to =
submitting any code it must go thru code review.</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>Please ask Andy to review the =
neteee changes. </FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>Either Andy or I will review =
the mgmtbus changes.</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>After the review has been =
completed you can run the submit.</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>The p4 change description =
must have a line such as:</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>&nbsp; reviewed by =
andys</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>The lack of this line is =
causing your checkin to fail.</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>Tim</FONT></DIV>=0A=
<DIV dir=3Dltr>&nbsp;</DIV></DIV>=0A=
<DIV dir=3Dltr><BR>=0A=
<HR tabIndex=3D-1>=0A=
<FONT face=3DTahoma size=3D2><B>From:</B> Richard Beck<BR><B>Sent:</B> =
Thu 5/17/2007 8:33 PM<BR><B>To:</B> Larry Scheer; Andy =
Sharp<BR><B>Cc:</B> Tim Gardner<BR><B>Subject:</B> neteee files =
integrated with the kernel<BR></FONT><BR></DIV>=0A=
<DIV>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>The =
initial checkin of the neteee files is in changelist</FONT></SPAN><SPAN =
lang=3Den-us></SPAN><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>s</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us><FONT face=3DArial size=3D2> 24011</FONT></SPAN><SPAN =
lang=3Den-us></SPAN><SPAN lang=3Den-us><FONT face=3DArial size=3D2> and =
24012.</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>Perforce =
seems a bit quirky, but then I</FONT></SPAN><SPAN =
lang=3Den-us></SPAN><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>&#8217;</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us><FONT face=3DArial size=3D2>m not very familiar with =
it.</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>Any =
suggestions on the following errors?:</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>&#65279;</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us><FONT face=3DArial size=3D2>1. </FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>p4 submit =
-i</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>Submit =
validation failed -- fix problems then use 'p4 submit -c =
2401</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN lang=3Den-us><FONT =
face=3DArial size=3D2>1</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us><FONT face=3DArial size=3D2>'.</FONT></SPAN><SPAN =
lang=3Den-us></SPAN><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2></FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN lang=3Den-us> =
</SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>Submit =
check 'Reviewed_By_Field_Not_Self2' failed: no error =
message</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>2. =
</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>p4 submit =
-c 24011</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial size=3D2>Change =
24011 belongs to user richardb.</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>bash-3.00$ whoami</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>richardb</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us></SPAN></P>=0A=
<P><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>1.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</FONT></SPAN><SPAN =
lang=3Den-us></SPAN><SPAN lang=3Den-us></SPAN><SPAN lang=3Den-us> <FONT =
face=3DArial size=3D2>Is there a review process that is part of checkin =
with Perforce?&nbsp;</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us> </SPAN><BR><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>2.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</FONT> <FONT face=3DArial =
size=3D2>Makes no sense.</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us></SPAN> </P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>I</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us><FONT face=3DArial size=3D2>&#8217;</FONT></SPAN><SPAN =
lang=3Den-us></SPAN><SPAN lang=3Den-us><FONT face=3DArial size=3D2>m =
sure we</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN lang=3Den-us><FONT =
face=3DArial size=3D2>&#8217;</FONT></SPAN><SPAN =
lang=3Den-us></SPAN><SPAN lang=3Den-us><FONT face=3DArial size=3D2>ll =
get this resolved tomorrow.</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>Regards,</FONT></SPAN></P>=0A=
<P align=3Dleft><SPAN lang=3Den-us><FONT face=3DArial =
size=3D2>Rich</FONT></SPAN><SPAN lang=3Den-us></SPAN><SPAN =
lang=3Den-us></SPAN></P><BR></DIV></BODY></HTML>
------_=_NextPart_001_01C79917.1D6B5102--
