X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7980A.73E92B7C@onstor-exch02.onstor.net>; Wed, 16 May 2007 15:35:06 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: FW: Request for Review 2 (Samba)
Date: Wed, 16 May 2007 15:35:06 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E022157D5@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Request for Review 2 (Samba)
Thread-Index: AceWftz70nRgCPJbSBy7fSHGNPCjqQAtGzBAADXHiaA=
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Samba change list again.

-----Original Message-----
From: Larry Scheer=20
Sent: Tuesday, May 15, 2007 1:57 PM
To: Andy Sharp
Subject: RE: Request for Review 2 (Samba)

Updated the Makefile with suggested changes. Added 2 new file openbsd.mk
and linux.mk.

Change 23934 by larrys@larrys-verify-depot on 2007/05/10 15:59:39
*pending*

        Samba 3.0.21a port for bobcat Linux.

Affected files ...

... //depot/cougar/nfx-tree/code/samba-3.21a/Makefile#3 edit
... //depot/cougar/nfx-tree/code/samba-3.21a/include/config.h#1 delete
... //depot/cougar/nfx-tree/code/samba-3.21a/include/linux.h#1 add
... //depot/cougar/nfx-tree/code/samba-3.21a/include/openbsd.h#1 branch
... //depot/cougar/nfx-tree/code/samba-3.21a/linux.mk#1 add
... //depot/cougar/nfx-tree/code/samba-3.21a/openbsd.mk#1 add
... //depot/cougar/nfx-tree/code/samba-3.21a/passdb/secrets.c#4 edit


-----Original Message-----
From: Andy Sharp=20
Sent: Monday, May 14, 2007 4:23 PM
To: Larry Scheer
Subject: Re: Request for Review 2 (Samba)

On Mon, 14 May 2007 12:30:59 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
> 	These are my Samba changes. My work space is
> /homes/larrys/perforce/trees/cougar.
>=20
> I am renaming config.h to openbsd.h. After this check-in I need to add
> back in config.h which will just look like this:
> #include OS_INCL
>=20
> I am adding linux.h which is config.h as created by the configure
> command.
>=20
> Change 23934 by larrys@larrys-verify-depot on 2007/05/10 15:59:39
> *pending*
>=20
>         Samba 3.0.21a port for bobcat Linux.
>=20
> Affected files ...
>=20
> ... //depot/cougar/nfx-tree/code/samba-3.21a/Makefile#3 edit
> ... //depot/cougar/nfx-tree/code/samba-3.21a/include/config.h#1 delete
> ... //depot/cougar/nfx-tree/code/samba-3.21a/include/linux.h#1 add
> ... //depot/cougar/nfx-tree/code/samba-3.21a/include/openbsd.h#1
> branch ... //depot/cougar/nfx-tree/code/samba-3.21a/passdb/secrets.c#4
> edit

nfx-tree/code/samba-3.21a/Makefile

     you know I don't want to see any ifdefs, which includes ifeq() in
Makefiles please replace these with the standard method for handling
this shiite=20
     line 1811, why did you @-out this link command? it really
shouldn't be.

nfx-tree/code/samba-3.21a/include/config.h

     ok
     delete nfx-tree/code/samba-3.21a/include/config.h

nfx-tree/code/samba-3.21a/passdb/secrets.c

     looks good

