X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C74BCF.DED6D4AD@onstor-exch02.onstor.net>; Thu, 8 Feb 2007 14:24:17 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Code review?
Date: Thu, 8 Feb 2007 14:24:17 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0221563D@onstor-exch02.onstor.net>
In-Reply-To: <20070208133551.655d7a89@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Code review?
Thread-Index: AcdLyRsIZSPlkFVJSfuYBgK+WqTo7wABqV+Q
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Yes and yes you did review it. I missed updating the system compare
functions.

Thanks for the review.

Larry

-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, February 08, 2007 1:36 PM
To: Larry Scheer
Subject: Re: Code review?

I thought you added the fseek awhile ago.  Didn't I already review that?

Anyway, it looks fine.

Cheers,

a

On Thu, 8 Feb 2007 10:55:12 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>   I fixed the problem with system compare -s only checking the primary
> flash. When I added the call to verify_install.sh in perform_comapre I
> did a cut and paste and forgot to change the command line option to
> use the compare_secondary rather than upgrade secondary.
>=20
> I also added the fseek for the log file so any error output from
> system compare will be placed at the end of the log.
>=20
> Let me know how this looks to you or any suggestions or comments.
>=20
> Larry
>=20
> =3D=3D=3D=3D =
//depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#6 -
>
/home/larrys/perforce/trees/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgr
> ade.c =3D=3D=3D=3D
> 2478c2478
> <                         patch_location, upgrade_secondary ? "-s" :
> "-p") ;
> ---
> >                         patch_location, compare_secondary ? "-s" :
> "-p") ;
> 2479a2480,2482
> >               if (sys_upgrade) {
> >                       fseek(sys_upgrade, 0, SEEK_END);
> >               }
> 2570a2574
> >
