X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C78D08.9659D48F@onstor-exch02.onstor.net>; Wed, 2 May 2007 15:24:02 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: obsolete/dead show_remote_version()?
Date: Wed, 2 May 2007 15:24:02 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E038C984A@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E038C980F@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: obsolete/dead show_remote_version()?
Thread-Index: AceNALsUD98LeHeZTxqRIeut4bk25QAAgA/QAABZgnAAAA1MsAABDVpg
References: <BB375AF679D4A34E9CA8DFA650E2B04E0221578D@onstor-exch02.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E038C980F@onstor-exch02.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Tim Gardner" <tim.gardner@onstor.com>,
	"Larry Scheer" <larry.scheer@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>

Yes remove it.

-----Original Message-----
From: Tim Gardner=20
Sent: Wednesday, May 02, 2007 2:55 PM
To: Larry Scheer; Andy Sharp; Maxim Kozlovsky
Subject: RE: obsolete/dead show_remote_version()?

The only document argument to system version is [-s].
Try running "system version biteme".
The SSC tries to mount biteme.

-----Original Message-----
From: Larry Scheer=20
Sent: Wednesday, May 02, 2007 2:53 PM
To: Tim Gardner; Andy Sharp; Maxim Kozlovsky
Subject: RE: obsolete/dead show_remote_version()?

It is documented

NAME

        system version          Displays the installed software version
of the
                                NAS Gateway.

SYNOPSIS

        system version [-s]

DESCRIPTION

        Displays a version string that identifies the system software
that is
        currently installed on the NAS Gateway.

        -s                      Option which displays the version of
system
                                software installed on the secondary
flash card
                                of the NAS Gateway.

SEE ALSO

        system show version     Displays detailed information software
and
                                hardware revision of the NAS Gateway.

-----Original Message-----
From: Tim Gardner=20
Sent: Wednesday, May 02, 2007 2:43 PM
To: Andy Sharp; Maxim Kozlovsky; Larry Scheer
Subject: RE: obsolete/dead show_remote_version()?

The option is not documented in the help text. I don't know about the
SAG.
I have never made use of this option and agree that we should either=20
remove it or document it. Is it possible the option is a diag user only
option?

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, May 02, 2007 2:28 PM
To: Maxim Kozlovsky; Larry Scheer; Tim Gardner
Subject: obsolete/dead show_remote_version()?

There is some code in cmd_upgrade.c, function do_show_version(), that
calls a function show_remote_version(argv[0]) that is called when
"system version" is followed by a word (or words) that is not
"-s".  The word in question is passed to this function.

This seems to be obsolete, dead, undocumented code.  Does anybody use
this undocumented (I think it's undocumented) command?  Does it even
work in some way?  I'm inclined to remove it since it doesn't seem to be
supported by the autocompletion/help and is inclined to give confusing
error message if you mistype the "-s" or have trailing garbage after
the "system version" command.  God forbid a user type something that
caused the command to hang waiting for an nfs mount that never happened
or happened very slowly, like only after a 2-3 minute DNS timeout.

a
