X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C78D12.B3206DCC@onstor-exch02.onstor.net>; Wed, 2 May 2007 16:36:25 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Wed, 2 May 2007 16:36:25 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E038C98F0@onstor-exch02.onstor.net>
In-Reply-To: <20070502163348.0a5bef63@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AceNElZna0A2RwTTTDqydZO7KxDeAAAAC6FQ
References: <BB375AF679D4A34E9CA8DFA650E2B04E038C952E@onstor-exch02.onstor.net> <20070502163348.0a5bef63@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

The size of long must be equal to size of pointer. At least that's what
I dimly recollect from somewhere.

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, May 02, 2007 4:34 PM
To: Maxim Kozlovsky
Subject: Re: Please review

On Wed, 2 May 2007 09:28:03 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> P4CLIENT=3Dmaximk-5
>=20
> Change 23808 by maximk@maximk-5 on 2007/05/02 08:15:16 *pending*
>=20
>         Fix the exception handler not using correct instruction to
> store the pointers on FC, which is 64 bit register size but 32 bit
> pointers.
>            This was causing infinite exception loop with unaligned
> double word
>            store.
>=20
> Affected files ...
>=20
> ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/exc-llhandler.S#1 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/except.h#1 edit


+/* Macro for storing a pointer.
+ */
+#ifdef __long64
+#define PTR_S sd
+#else
+#define PTR_S sw
+#endif
+

This looks more like a macro for storing a long when a long is 64
bits.  That might be what you want, I can't tell.  But it seems to me
that if the macro is for pointers, it should be based on the size of
pointers.  I'm just sayin'.

> ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/nmi.S#1 edit
