X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C78B94.CFB13C9E@onstor-exch02.onstor.net>; Mon, 30 Apr 2007 19:02:45 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C78B94.CFB13C9E"
References: <WEBMAILjdlkmKfzTDz600000593@mail.onstor.com> <20070430170008.1bf26a46@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 23778 for review
Date: Mon, 30 Apr 2007 19:02:45 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0A91E4@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 23778 for review
Thread-Index: AceLg64VaSYVTVrxQqCYx6vQeTBFGgADtRxC
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C78B94.CFB13C9E
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

I want to say no that you don't have two different scripts running =
because system compare runs the script just installed. It's a work-flow =
thing. After talking to QA (Sandrine) this is the perceived workflow:

1. upgrade system --> runs verify_install.sh that is in the distribution =
and upgrades the system
2. run system compare.--> runs the verify_install.sh that was just =
installed and compares a distribution to what is installed.

Before this change you did have system upgrade and system compare =
running two different compare scripts. Which is what I perceived to be =
the problem. The system compare was running the verify_install.sh from =
the old distribution which didn't have the logic to handle the new flash =
layout. With this change the verify_install.sh that is run is the one =
that upgraded the system and is compatible with what is installed and =
can compare older versions.

One thing that Sandrine mentioned, and I already documented in the 2.2.3 =
to 3.0.0.0 version of the upgrade release notes, is system compare is no =
longer needed because the upgrade is verifying the installation =
automatically.

Anyway, I explained this to Tim and he approved the change.

Larry

=20



-----Original Message-----
From: Andy Sharp
Sent: Mon 4/30/2007 5:00 PM
To: Larry Scheer; Tim Gardner
Subject: Re: PERFORCE change 23778 for review
=20
I rejected this change because upgrading between submittals in Delorean
we all agreed isn't supported, and also because it's very broken.  You
have _system compare_ running one script, and _system upgrade_ running
another, exactly the kind of thing you should not, and I believe, can
not, do.

a

On 30 Apr 2007 15:41:49 -0700 Larry Scheer <larry.scheer@onstor.com>
wrote:

> Change 23778 by larrys@larrys-r14-dmip on 2007/04/30 14:31:52
>=20
> 	Fix for defect 18379 system compare aborting prematurely.
> 	Reviewed by: timg
>=20
> Affected files ...
>=20
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#16 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/verify_install.sh#13
> edit
>=20


------_=_NextPart_001_01C78B94.CFB13C9E
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7652.24">
<TITLE>RE: PERFORCE change 23778 for review</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>I want to say no that you don't have two different =
scripts running because system compare runs the script just installed. =
It's a work-flow thing. After talking to QA (Sandrine) this is the =
perceived workflow:<BR>
<BR>
1. upgrade system --&gt; runs verify_install.sh that is in the =
distribution and upgrades the system<BR>
2. run system compare.--&gt; runs the verify_install.sh that was just =
installed and compares a distribution to what is installed.<BR>
<BR>
Before this change you did have system upgrade and system compare =
running two different compare scripts. Which is what I perceived to be =
the problem. The system compare was running the verify_install.sh from =
the old distribution which didn't have the logic to handle the new flash =
layout. With this change the verify_install.sh that is run is the one =
that upgraded the system and is compatible with what is installed and =
can compare older versions.<BR>
<BR>
One thing that Sandrine mentioned, and I already documented in the 2.2.3 =
to 3.0.0.0 version of the upgrade release notes, is system compare is no =
longer needed because the upgrade is verifying the installation =
automatically.<BR>
<BR>
Anyway, I explained this to Tim and he approved the change.<BR>
<BR>
Larry<BR>
<BR>
<BR>
<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Mon 4/30/2007 5:00 PM<BR>
To: Larry Scheer; Tim Gardner<BR>
Subject: Re: PERFORCE change 23778 for review<BR>
<BR>
I rejected this change because upgrading between submittals in =
Delorean<BR>
we all agreed isn't supported, and also because it's very broken.&nbsp; =
You<BR>
have _system compare_ running one script, and _system upgrade_ =
running<BR>
another, exactly the kind of thing you should not, and I believe, =
can<BR>
not, do.<BR>
<BR>
a<BR>
<BR>
On 30 Apr 2007 15:41:49 -0700 Larry Scheer =
&lt;larry.scheer@onstor.com&gt;<BR>
wrote:<BR>
<BR>
&gt; Change 23778 by larrys@larrys-r14-dmip on 2007/04/30 14:31:52<BR>
&gt;<BR>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Fix for defect 18379 system compare =
aborting prematurely.<BR>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Reviewed by: timg<BR>
&gt;<BR>
&gt; Affected files ...<BR>
&gt;<BR>
&gt; ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#16 =
edit<BR>
&gt; ... =
//depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/verify_install.sh#13<BR>
&gt; edit<BR>
&gt;<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C78B94.CFB13C9E--
