X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C78855.04C4E98E@onstor-exch02.onstor.net>; Thu, 26 Apr 2007 15:48:33 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: need your review of some improvements for flash_install.sh
Date: Thu, 26 Apr 2007 15:48:33 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0221576E@onstor-exch02.onstor.net>
In-Reply-To: <20070426112343.69f6eaf6@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: need your review of some improvements for flash_install.sh
Thread-Index: AceIMAWFSifMmxK8StGoftRuwwn2ygAEgCjw
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

File: Tools/flash_install.sh
Line 34: foo=3D"`df / | tail -1`"

Just a comment for your consideration, I've gotten out of the habit of
using tail -1 with df and started using fgrep /dev (or variants using
grep) mainly because of Linux and ext3 file systems the df can span 3
lines and the device is the middle line. The tail -1 works for now, and
may continue to work for the foreseeable future, but it may not always.

It is up to you if you want to change it or leave it because line 35
will need to change when we switch to an ext2/3 file system anyway.

Line 298: echo "I can't file the software distribution in '$sdir'."
                        ^^^^  You mean "find" correct?


File: etc/rc
Line 157: if grep /usr will also match /usr/local/agile and
/usr/local/agile/conf

Line 164: if grep /usr/local/agile will also match /usr/local/agile/conf


-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, April 26, 2007 11:24 AM
To: Larry Scheer
Subject: need your review of some improvements for flash_install.sh

perforce cl 23729
client ripper
branch FB-DELOREAN


Some improvements to flash_install:
       =20
        Improve the interactivity:
         - let's you try again if you give a bogus answer
         - instead of asking you an obvious question, it
           automatically selects the secondary CF card
           to format if your root filesystem is on a CF card.
       =20
        Better command argument checking
       =20
        Added some additional sanity checking
       =20
        Fixed up the error paths to exit more gracefully
