X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7829B.1B2006E7@onstor-exch02.onstor.net>; Thu, 19 Apr 2007 08:55:08 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Next please review
Date: Thu, 19 Apr 2007 08:55:09 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0351BC47@onstor-exch02.onstor.net>
In-Reply-To: <20070418191621.7284411e@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Next please review
Thread-Index: AceCKLksbcbhIHtTT1yh49Z1mzwAyAAclqbw
References: <BB375AF679D4A34E9CA8DFA650E2B04E0351BA6E@onstor-exch02.onstor.net> <20070418191621.7284411e@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

ok

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, April 18, 2007 7:16 PM
To: Maxim Kozlovsky
Subject: Re: Next please review

You need a whitespace violation detector.  We should add one to our
perforce commit triggers.

Here's the list:


nfx-tree/code/sendmail/Makefile

     please tell me you didn't spend any time porting sendmail.  we
     aren't using it in linux.  just remove it from the SUBDIRS list in
     nfx-tree/code or wherever it is.

nfx-tree/code/sm-bsd-snmpd/agent/Makefile

     looks good

nfx-tree/code/sm-chassis/Makefile

     fantastico

nfx-tree/code/sm-chassis/cm-util-bc.c

     fantastico

nfx-tree/code/sm-chassis/linux.h

     hexellent

nfx-tree/code/sm-chassis/openbsd.h

     whatever

nfx-tree/code/sm-ea/Makefile

     looks good

nfx-tree/code/sm-ea/ea-nis.c

     just write an isblank(), put it in a global include for linux, and
     save yourself a lot of time ~:^)

nfx-tree/code/sm-ea/ea-util.c

     looks good

nfx-tree/code/sm-event/Makefile

     looks good

nfx-tree/code/sm-event/event-api.c

     looks good

nfx-tree/code/sm-evm/Makefile

     looks good

nfx-tree/code/sm-file/Makefile

     looks good

nfx-tree/code/sm-fs/Makefile

     looks good

nfx-tree/code/sm-fs/fs-shell.c

     looks good

nfx-tree/code/sm-ipmd/Makefile

     looks good

nfx-tree/code/sm-ipmd/ipmd-kern-linux.c

     fix whitespace

nfx-tree/code/sm-ipmd/ipmd-kern-openbsd.c

     fix whitespace

nfx-tree/code/sm-ipmd/ipmd-kern.c

     whatever

nfx-tree/code/sm-ipmd/ipmd-util.c

     uh, you can safely get rid of the ifdef, no?  we always will
     include those files on any known build.

nfx-tree/code/sm-ipmd/ipmd.c

     line 38, just get rid of the ifdef, those files always to be
     included

nfx-tree/code/sm-opt/Makefile

     looks good

nfx-tree/code/sm-sct/Makefile

     looks good

nfx-tree/code/sm-sct/linux.h

     ok

nfx-tree/code/sm-sct/openbsd.h

     whatever

nfx-tree/code/sm-sct/sct-http.c

     looks good

nfx-tree/code/sm-sct/sct.c

     looks good

nfx-tree/code/sm-sct/taskmgr.c

     looks good

nfx-tree/code/sm-sdm/Makefile

     looks good

nfx-tree/code/sm-sdm/sdm-init-disk.c

     looks good

nfx-tree/code/sm-sdm/sdm-init.c

     looks good

nfx-tree/code/sm-sdm/sdm-msg.c

     looks good

nfx-tree/code/sm-sdm/storage.c

     excellent

nfx-tree/code/sm-spm/Makefile

     looks good

nfx-tree/code/sm-tape/Makefile

     looks good

nfx-tree/code/ssc-authen-lib/admin-session.c

     looks good

nfx-tree/code/ssc-authen-lib/authen-lib.c

     looks good

nfx-tree/code/ssc-authen-lib/dom-cfg.c

     looks good

nfx-tree/code/ssc-authentication/Makefile

     looks good

nfx-tree/code/ssc-authentication/auth-agent.c

     looks good

nfx-tree/code/ssc-cluster/clusdb-api.c

     looks good

nfx-tree/code/ssc-cluster/clusdb-export-common.c

     looks good

nfx-tree/code/ssc-cluster/clusdb-tools.c

     looks good

nfx-tree/code/ssc-cluster/cluster-gns-api.c

     looks good

nfx-tree/code/ssc-cluster/cluster-test.c

     looks good

nfx-tree/code/ssc-cluster/cluster-util.c

     looks good

nfx-tree/code/ssc-cluster/cluster-vsvr-api.c

     looks good

nfx-tree/code/ssc-crashsave/Makefile

     looks good

nfx-tree/code/ssc-crashsave/crashsave-int.h

     what's with the ifdef BOBCAT

     is the bobcat openbsd, bobcat linux, bobcat alles ... and cougar?
     same as bobcat?  and cheetah?  are all boxes except bobcat 2MiB?

nfx-tree/code/ssc-crashsave/crashsave.c

     looks good

nfx-tree/code/ssc-crashsave/linux.c

     ok

nfx-tree/code/ssc-crashsave/openbsd.c

     several whitespace violations

nfx-tree/code/ssc-elog/Makefile

     looks good

nfx-tree/code/ssc-ncm/Makefile

     looks good

nfx-tree/code/ssc-ndmp/Makefile

     looks good

nfx-tree/code/ssc-ndmp/ndmp-trace-msg.c

     looks good

nfx-tree/code/ssc-ndmp/ndmp-ui.c

     looks good

nfx-tree/code/ssc-nfxnis/nfxnis-lib.h

     looks good

nfx-tree/code/ssc-nfxsh/Makefile

     nice

nfx-tree/code/ssc-nfxsh/am_get_our_addr-linux.c

     fix spacing: no space between function name and open paren

nfx-tree/code/ssc-nfxsh/am_get_our_addr-openbsd.c

     ugly whitespace violations

nfx-tree/code/ssc-nfxsh/am_get_our_addr.c

     ogay

nfx-tree/code/ssc-nfxsh/cmd_arp.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_autosupport.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_cifs.c

     don't use one long string, break them up.  there are several.

     "words words words words words words words words words words "
     "words words words words words words words words words words "
     "words words words words words words words words words words."

nfx-tree/code/ssc-nfxsh/cmd_cluster.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_cshare.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_domain.c

     line 161, 190 use multiple strings

     line 676, 715 revert because you will have added a isblank
     function by now

nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c

     line 412, at least make it "fdisk" ~:^)

     pattern_unlink() and do_reset_config() tons of whitespace
     violations, mostly trailing whitespace.

nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c

     ok

nfx-tree/code/ssc-nfxsh/cmd_flash.c

     ok

nfx-tree/code/ssc-nfxsh/cmd_gns.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_license.c

     ok

nfx-tree/code/ssc-nfxsh/cmd_localmap.c

     line 563, 705, 789 can be reverted to isblank since you're going
     to have that implemented already.

nfx-tree/code/ssc-nfxsh/cmd_lvol.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_privileges.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_system-linux.c

     trailing whitespace, line 26

nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c

     ew, trailing whitespace

nfx-tree/code/ssc-nfxsh/cmd_system.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_upgrade.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_vol.c

     looks good

nfx-tree/code/ssc-nfxsh/command.h

     looks good

nfx-tree/code/ssc-nfxsh/config.h

     ok

nfx-tree/code/ssc-nfxsh/getopt.c

     looks good

nfx-tree/code/ssc-nfxsh/linux.h

     trailing ws, last line

nfx-tree/code/ssc-nfxsh/menu.c

     looks good

nfx-tree/code/ssc-nfxsh/nfxsh.h

     looks good

nfx-tree/code/ssc-nfxsh/openbsd.h

     ok

nfx-tree/code/ssc-optlib/config_rules.c

     looks good

nfx-tree/code/ssc-rmc/Makefile

     looks good

nfx-tree/code/ssc-sanm/Makefile

     looks good

nfx-tree/code/ssc-sanm/sanm-main.c

     looks good

nfx-tree/code/ssc-sanm/sanm-msg.c

     looks good

nfx-tree/code/ssc-socat/Makefile

     looks good

nfx-tree/code/ssc-sshd-kb5/Makefile

     looks good

nfx-tree/code/ssc-sshd/Makefile

     looks good

nfx-tree/code/ssc-timekeeper/Makefile

     looks good

nfx-tree/code/ssc-vsd/vs-nisfile.c

     revert the isblank removals

nfx-tree/code/ssc-vtm/Makefile

     looks good

nfx-tree/code/ssc-vtm/vtm-common.c

     looks good

nfx-tree/code/ssc-vtm/vtm-failover.c

     looks good

nfx-tree/code/ssc-vtm/vtm-msg.c

     looks good



On Wed, 18 Apr 2007 17:54:47 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Few more files - change #23633=20
>=20
> ... //depot/cougar/nfx-tree/code/sendmail/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-bsd-snmpd/agent/Makefile#2 edit
> ... //depot/cougar/nfx-tree/code/sm-chassis/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-chassis/cm-util-bc.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-chassis/linux.h#1 add
> ... //depot/cougar/nfx-tree/code/sm-chassis/openbsd.h#1 add
> ... //depot/cougar/nfx-tree/code/sm-ea/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-ea/ea-nis.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-ea/ea-util.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-event/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-event/event-api.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-evm/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-file/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-fs/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-fs/fs-shell.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-ipmd/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-ipmd/ipmd-kern-linux.c#1 add
> ... //depot/cougar/nfx-tree/code/sm-ipmd/ipmd-kern-openbsd.c#1 add
> ... //depot/cougar/nfx-tree/code/sm-ipmd/ipmd-kern.c#1 delete
> ... //depot/cougar/nfx-tree/code/sm-ipmd/ipmd-util.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-ipmd/ipmd.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-opt/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-sct/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-sct/linux.h#1 add
> ... //depot/cougar/nfx-tree/code/sm-sct/openbsd.h#1 add
> ... //depot/cougar/nfx-tree/code/sm-sct/sct-http.c#2 edit
> ... //depot/cougar/nfx-tree/code/sm-sct/sct.c#2 edit
> ... //depot/cougar/nfx-tree/code/sm-sct/taskmgr.c#3 edit
> ... //depot/cougar/nfx-tree/code/sm-sdm/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-sdm/sdm-init-disk.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-sdm/sdm-init.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-sdm/sdm-msg.c#3 edit
> ... //depot/cougar/nfx-tree/code/sm-sdm/storage.c#1 edit
> ... //depot/cougar/nfx-tree/code/sm-spm/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-tape/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-authen-lib/admin-session.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-authen-lib/authen-lib.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-authen-lib/dom-cfg.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-authentication/Makefile#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-authentication/auth-agent.c#2
> edit ... //depot/cougar/nfx-tree/code/ssc-cluster/clusdb-api.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-cluster/clusdb-export-common.c#2
> edit
> ... //depot/cougar/nfx-tree/code/ssc-cluster/clusdb-tools.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-cluster/cluster-gns-api.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-cluster/cluster-test.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-cluster/cluster-util.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-cluster/cluster-vsvr-api.c#3 edit
> ... //depot/cougar/nfx-tree/code/ssc-crashsave/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-crashsave/crashsave-int.h#1 add
> ... //depot/cougar/nfx-tree/code/ssc-crashsave/crashsave.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-crashsave/linux.c#1 add
> ... //depot/cougar/nfx-tree/code/ssc-crashsave/openbsd.c#1 add
> ... //depot/cougar/nfx-tree/code/ssc-elog/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-ncm/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-ndmp/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-ndmp/ndmp-trace-msg.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-ndmp/ndmp-ui.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-lib.h#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/Makefile#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/am_get_our_addr-linux.c#1
> add ...
//depot/cougar/nfx-tree/code/ssc-nfxsh/am_get_our_addr-openbsd.c#1
> add
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/am_get_our_addr.c#1 delete
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_arp.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_cifs.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_cshare.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_domain.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#1 add
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#1 add
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_flash.c#1 delete
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_gns.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_license.c#1 delete
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_localmap.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_lvol.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_privileges.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_system-linux.c#1 add
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#1 add
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_system.c#3 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#3 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/cmd_vol.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/command.h#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/config.h#1 add
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/getopt.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/linux.h#1 add
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/menu.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/nfxsh.h#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-nfxsh/openbsd.h#1 add
> ... //depot/cougar/nfx-tree/code/ssc-optlib/config_rules.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-rmc/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sanm/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sanm/sanm-main.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sanm/sanm-msg.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-socat/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/Makefile#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-timekeeper/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-vsd/vs-nisfile.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-vtm/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-vtm/vtm-common.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-vtm/vtm-failover.c#2 edit
> ... //depot/cougar/nfx-tree/code/ssc-vtm/vtm-msg.c#3 edit
