X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C77C72.22D31430@onstor-exch02.onstor.net>; Wed, 11 Apr 2007 12:46:45 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review (fix for TED00018533)
Date: Wed, 11 Apr 2007 12:46:45 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0221571F@onstor-exch02.onstor.net>
In-Reply-To: <20070411115920.77807105@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review (fix for TED00018533)
Thread-Index: Acd8a4NyZj0qoHeASj6rvBnDrHtNpAABpp4Q
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Looks good.

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, April 11, 2007 11:59 AM
To: Larry Scheer
Subject: please review (fix for TED00018533)

Hi Larry,

Please review the fix for=20

TED00018533 - check for minimum CF size in "system copy init" is broken

The change is to cmd_flash.c only, and the diff is:

=3D=3D=3D=3D //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#7 -
/homes/andys/src/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c =
=3D=3D=3D=3D
@@ -137,14 +137,12 @@
 static int
 disk_name(size_t disk_blocks, size_t block_size, char *dtab_name)
 {
-    uint64_t dsize;
        int ret_val;
 #define CF_SIZE_MIN (490 * 2048)  /* 512MB flash with a few blocks
missing */
=20
-    dsize =3D disk_blocks * block_size;
        sprintf(dtab_name, "cf%d.label", disk_blocks / 2048); /* MiB */
        printf("Secondary CF card is %d MiB\n", disk_blocks / 2048);
-       if (dsize > CF_SIZE_MIN) {
+       if (disk_blocks > CF_SIZE_MIN) {
                char fullname[128];
                FILE *dtf;
