X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C77E0B.661C6CA2@onstor-exch02.onstor.net>; Fri, 13 Apr 2007 13:36:22 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C77E0B.661C6CA2"
Content-class: urn:content-classes:message
Subject: RE: please review
Date: Fri, 13 Apr 2007 13:36:22 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0221572E@onstor-exch02.onstor.net>
In-Reply-To: <20070413120157.07f8182b@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review
Thread-Index: Acd9/jZlJeiYqhL1QZaOuqDa18yiQQADA6mA
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C77E0B.661C6CA2
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

My question was about mdrive_install.sh, I don't know if we use this
file, but your change the openbsd/src/Makefile removes it from the list
of files that are installed. If we don't use this file then your change
is ok. But if it is used then the file will be MIA when a make release
is done. Looking at the file it just appears to be the prototype
install_flash_512.sh was created from. So, my guess it is cruft and we
don't need to be hauling it around in every release.

=20

From mdrive_install.sh:

chroot $1 disklabel -w wd0 'IBM-DSCM-11000 '

=20

newfs /dev/rwd0a

newfs /dev/rwd0d

newfs /dev/rwd0e

newfs /dev/rwd0f

newfs /dev/rwd0g

=20

L.

=20

P.S. I am still looking at changes I have a comment about cmd_flash.c
hope to be done shortly. (Had a lunch meeting just got back 15 minutes
ago.)

=20

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, April 13, 2007 12:02 PM
To: Larry Scheer
Subject: Re: please review

=20

I'm not sure I did the right thing on this, but I wanted to rename it

to old_mdrive_fstab, and then after that was committed, add the new

version as a new file.  Which is what I was trying to explain with all

that stuff about the new file.  But reading it I guess it didn't make

much sense.

=20

A rename appears as a delete and an add I think.

=20

Hope that answers your question.

=20

Cheers,

=20

a

=20

=20

On Fri, 13 Apr 2007 10:57:38 -0700 "Larry Scheer"

<larry.scheer@onstor.com> wrote:

=20

> Just starting to look at this....

> I have one question about the change to openbsd/src/etc/Makefile.

> What happened to mdrive_install.sh? Is it deprecated? Was its

> functionality moved to src/etc/rc. (I have looked at the two files

> yet.) I just want to make sure this wasn't an unintentional delete.

>=20

> L.

>=20

> -----Original Message-----

> From: Andy Sharp=20

> Sent: Thursday, April 12, 2007 11:20 PM

> To: Larry Scheer

> Subject: please review

>=20

> change 23496 client ripper

>=20

>=20

> let me know if you have any questions

>=20

> i included the code to refuse to upgrade to secondary flash w/ old

> layout

>=20

> there is another new file, openbsd/src/etc/mdrive_fstab that will be

> added after this changelist is committed.  it currently sits in that

> directory under the name new_mdrive_fstab.  it may also be there under

> it's real name but that's just so that 'make release' will work right

> so i could test it.

>=20

>=20

> Change 23496 by andys@ripper on 2007/04/10 18:25:58 *pending*

>=20

>         New flash_install.sh script and friends to support new CF

> layout.

>        =20

>         TED00018269 need to change master install scripts for new CF

> layout

>=20

> Affected files ...

>=20

> ... //depot/FB-DELOREAN/nfx-tree/Makefile#7 edit

> ... //depot/FB-DELOREAN/nfx-tree/Tools/flash_install.sh#1 add

> ... //depot/FB-DELOREAN/nfx-tree/Tools/flash_install_512.sh#1 delete

> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#9 edit

> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#14 edit

> ... //depot/FB-DELOREAN/openbsd/src/etc/Makefile#1 edit

> ... //depot/FB-DELOREAN/openbsd/src/etc/mdrive_fstab#1 delete

> ... //depot/FB-DELOREAN/openbsd/src/etc/old_mdrive_fstab#1 add

> ... //depot/FB-DELOREAN/openbsd/src/etc/rc#2 edit


------_=_NextPart_001_01C77E0B.661C6CA2
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" =
xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns=3D"http://www.w3.org/TR/REC-html40">

<head>
<meta http-equiv=3DContent-Type content=3D"text/html; =
charset=3Dus-ascii">
<meta name=3DGenerator content=3D"Microsoft Word 11 (filtered medium)">
<style>
<!--
 /* Style Definitions */
 p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:12.0pt;
	font-family:"Times New Roman";}
a:link, span.MsoHyperlink
	{color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{color:navy;
	text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:10.0pt;
	font-family:"Courier New";}
@page Section1
	{size:8.5in 11.0in;
	margin:1.0in 77.95pt 1.0in 77.95pt;}
div.Section1
	{page:Section1;}
-->
</style>

</head>

<body lang=3DEN-US link=3Dblue vlink=3Dnavy>

<div class=3DSection1>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>My question was about mdrive_install.sh, I don't know if we use =
this
file, but your change the openbsd/src/Makefile removes it from the list =
of
files that are installed. If we don't use this file then your change is =
ok. But
if it is used then the file will be MIA when a make release is done. =
Looking at
the file it just appears to be the prototype install_flash_512.sh was =
created
from. So, my guess it is cruft and we don't need to be hauling it around =
in
every release.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>From mdrive_install.sh:<o:p></o:p></span></font></p>

<p class=3DMsoPlainText style=3D'margin-left:.5in'><font size=3D2 =
face=3D"Courier New"><span
style=3D'font-size:10.0pt'>chroot $1 disklabel -w wd0 'IBM-DSCM-11000 =
'<o:p></o:p></span></font></p>

<p class=3DMsoPlainText style=3D'margin-left:.5in'><font size=3D2 =
face=3D"Courier New"><span
style=3D'font-size:10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText style=3D'margin-left:.5in'><font size=3D2 =
face=3D"Courier New"><span
style=3D'font-size:10.0pt'>newfs /dev/rwd0a<o:p></o:p></span></font></p>

<p class=3DMsoPlainText style=3D'margin-left:.5in'><font size=3D2 =
face=3D"Courier New"><span
style=3D'font-size:10.0pt'>newfs /dev/rwd0d<o:p></o:p></span></font></p>

<p class=3DMsoPlainText style=3D'margin-left:.5in'><font size=3D2 =
face=3D"Courier New"><span
style=3D'font-size:10.0pt'>newfs /dev/rwd0e<o:p></o:p></span></font></p>

<p class=3DMsoPlainText style=3D'margin-left:.5in'><font size=3D2 =
face=3D"Courier New"><span
style=3D'font-size:10.0pt'>newfs /dev/rwd0f<o:p></o:p></span></font></p>

<p class=3DMsoPlainText style=3D'margin-left:.5in'><font size=3D2 =
face=3D"Courier New"><span
style=3D'font-size:10.0pt'>newfs /dev/rwd0g<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>L.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>P.S. I am still looking at changes I have a comment about =
cmd_flash.c
hope to be done shortly. (Had a lunch meeting just got back 15 minutes =
ago.)<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>-----Original Message-----<br>
From: Andy Sharp <br>
Sent: Friday, April 13, 2007 12:02 PM<br>
To: Larry Scheer<br>
Subject: Re: please review</span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>I'm not sure I did the right thing on this, but I wanted to =
rename it<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>to old_mdrive_fstab, and then after that was committed, add the =
new<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>version as a new file.&nbsp; Which is what I was trying to =
explain with
all<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>that stuff about the new file.&nbsp; But reading it I guess it =
didn't
make<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>much sense.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>A rename appears as a delete and an add I =
think.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>Hope that answers your question.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>Cheers,<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>a<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>On Fri, 13 Apr 2007 10:57:38 -0700 &quot;Larry =
Scheer&quot;<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&lt;larry.scheer@onstor.com&gt; =
wrote:<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'><o:p>&nbsp;</o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; Just starting to look at =
this....<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; I have one question about the change to =
openbsd/src/etc/Makefile.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; What happened to mdrive_install.sh? Is it deprecated? Was =
its<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; functionality moved to src/etc/rc. (I have looked at the =
two files<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; yet.) I just want to make sure this wasn't an unintentional
delete.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; L.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; -----Original Message-----<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; From: Andy Sharp <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; Sent: Thursday, April 12, 2007 11:20 =
PM<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; To: Larry Scheer<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; Subject: please review<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; change 23496 client ripper<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; let me know if you have any =
questions<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; i included the code to refuse to upgrade to secondary flash =
w/ old<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; layout<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; there is another new file, openbsd/src/etc/mdrive_fstab =
that will
be<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; added after this changelist is committed.&nbsp; it =
currently sits
in that<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; directory under the name new_mdrive_fstab.&nbsp; it may =
also be
there under<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; it's real name but that's just so that 'make release' will =
work
right<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; so i could test it.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; Change 23496 by andys@ripper on 2007/04/10 18:25:58 =
*pending*<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; New
flash_install.sh script and friends to support new =
CF<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; layout.<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; TED00018269 =
need
to change master install scripts for new CF<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; layout<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; Affected files ...<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; <o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... //depot/FB-DELOREAN/nfx-tree/Makefile#7 =
edit<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... //depot/FB-DELOREAN/nfx-tree/Tools/flash_install.sh#1 =
add<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... =
//depot/FB-DELOREAN/nfx-tree/Tools/flash_install_512.sh#1
delete<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... =
//depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#9 =
edit<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... =
//depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#14
edit<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... //depot/FB-DELOREAN/openbsd/src/etc/Makefile#1 =
edit<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... //depot/FB-DELOREAN/openbsd/src/etc/mdrive_fstab#1 =
delete<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... //depot/FB-DELOREAN/openbsd/src/etc/old_mdrive_fstab#1 =
add<o:p></o:p></span></font></p>

<p class=3DMsoPlainText><font size=3D2 face=3D"Courier New"><span =
style=3D'font-size:
10.0pt'>&gt; ... //depot/FB-DELOREAN/openbsd/src/etc/rc#2 =
edit<o:p></o:p></span></font></p>

</div>

</body>

</html>

------_=_NextPart_001_01C77E0B.661C6CA2--
