X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C77E0D.712E815A@onstor-exch02.onstor.net>; Fri, 13 Apr 2007 13:51:00 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review
Date: Fri, 13 Apr 2007 13:51:00 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0221572F@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221572C@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review
Thread-Index: Acd9k75v5MYFadfiRui9c6OyNcL4QwAYPA7QAAHTCLA=
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>

In cmd_flash.c the comment on line 1133 and 1134 regarding "the turd is
toast" won't make sense to anybody but me and you. It was also
confusing. I don't understand why old versus new layout is mentioned in
the comment. If any files are copied to the secondary flash, regardless
of flash layout the cookie/turd should go away, correct? We only want it
to be there when the flash is newly initialized and no files copied.
Shouldn't the delete be independent of format?=20

The rest looks ok to me.

L.


-----Original Message-----
From: Larry Scheer=20
Sent: Friday, April 13, 2007 10:58 AM
To: Andy Sharp
Cc: Larry Scheer
Subject: RE: please review

Just starting to look at this....
I have one question about the change to openbsd/src/etc/Makefile.
What happened to mdrive_install.sh? Is it deprecated? Was its
functionality moved to src/etc/rc. (I have looked at the two files yet.)
I just want to make sure this wasn't an unintentional delete.

L.

-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, April 12, 2007 11:20 PM
To: Larry Scheer
Subject: please review

change 23496 client ripper


let me know if you have any questions

i included the code to refuse to upgrade to secondary flash w/ old
layout

there is another new file, openbsd/src/etc/mdrive_fstab that will be
added after this changelist is committed.  it currently sits in that
directory under the name new_mdrive_fstab.  it may also be there under
it's real name but that's just so that 'make release' will work right
so i could test it.


Change 23496 by andys@ripper on 2007/04/10 18:25:58 *pending*

        New flash_install.sh script and friends to support new CF
layout.
       =20
        TED00018269 need to change master install scripts for new CF
layout

Affected files ...

... //depot/FB-DELOREAN/nfx-tree/Makefile#7 edit
... //depot/FB-DELOREAN/nfx-tree/Tools/flash_install.sh#1 add
... //depot/FB-DELOREAN/nfx-tree/Tools/flash_install_512.sh#1 delete
... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#9 edit
... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#14 edit
... //depot/FB-DELOREAN/openbsd/src/etc/Makefile#1 edit
... //depot/FB-DELOREAN/openbsd/src/etc/mdrive_fstab#1 delete
... //depot/FB-DELOREAN/openbsd/src/etc/old_mdrive_fstab#1 add
... //depot/FB-DELOREAN/openbsd/src/etc/rc#2 edit
