X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C77B11.6D825398@onstor-exch02.onstor.net>; Mon, 9 Apr 2007 18:41:58 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C77B11.6D825398"
References: <BB375AF679D4A34E9CA8DFA650E2B04E02215715@onstor-exch02.onstor.net> <20070409164943.2d7c4f6b@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: Code review request
Date: Mon, 9 Apr 2007 18:41:58 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0A91B1@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Code review request
Thread-Index: Acd7Ab+HY0pxVZexR3CC0zK7bVhYgAADdqCt
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C77B11.6D825398
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Comments in line below maked with '--'.


-----Original Message-----
From: Andy Sharp
Sent: Mon 4/9/2007 4:49 PM
To: Larry Scheer
Subject: Re: Code review request
=20
On Mon, 9 Apr 2007 14:34:36 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>    When you have a moment can you review the following files. They are
> in my home dir so you should have access to them.
>=20
> Script to create cross packages and comvert them to rpms:
> =09
> /homes/larrys/perforce/trees/cougar/linux/pkg-tools/deb2cross2rpm

I don't know if it works, but it looks OK. I think if you invoke it
without arguments it just silently exits, but it that's what you want
it to do, then that's OK too.

-- Yea, I need to add a usage message and exit when there are no args.
-- Musta forgot that...

> Global makefiles
> =09
> /homes/larrys/perforce/trees/cougar/nfx-tree/Tools/defs.mk

I don't think this is ready yet.  We should sit down and discuss the
overall plan for the Makefiles and includes and stuff.  I just want to
hear what you have in mind and so forth.  I'm not clear on where this
file fits in and at what stages and so forth.  And I'm not too thrilled
with the massive number of ifdefs (ifeqs in makefiles).

-- My changes are not that much to this file. This is an Onstor =
Original,=20
-- 90% of what you are looking at is legacy.
-- I have been talking to Jeff about splitting this file apart. Making=20
-- massive design changes to this file has always been risky since=20
-- everything uses it, even the prom builds use it, so I am told.=20

> /homes/larrys/perforce/trees/cougar/nfx-tree/Tools/tool-chain-pkg.mk

Fill in the first TODO ~:^)

I think you're getting there, or maybe you're already there, but let's
sit down (stand up?) tomorrow and you can run me through this stuff a
little bit before you check it in if that's OK.  Tomorrow morning is
fine if that works for you. Maybe grab a room with a whiteboard.

Line 59 has trailing whitespace.

I just want to make sure that I understand the large strokes of the
overall flow of the design, and what stage we think we're in and what
direction we're going to be going in as things progress.

-- Ok, I need to see what tomorrow brings, but maybe we can do a=20
-- whiteboard talk before lunch.

Cheers,

a


------_=_NextPart_001_01C77B11.6D825398
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7652.24">
<TITLE>RE: Code review request</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>Comments in line below maked with '--'.<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Mon 4/9/2007 4:49 PM<BR>
To: Larry Scheer<BR>
Subject: Re: Code review request<BR>
<BR>
On Mon, 9 Apr 2007 14:34:36 -0700 &quot;Larry Scheer&quot;<BR>
&lt;larry.scheer@onstor.com&gt; wrote:<BR>
<BR>
&gt; Andy,<BR>
&gt;&nbsp;&nbsp;&nbsp; When you have a moment can you review the =
following files. They are<BR>
&gt; in my home dir so you should have access to them.<BR>
&gt;<BR>
&gt; Script to create cross packages and comvert them to rpms:<BR>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR>
&gt; =
/homes/larrys/perforce/trees/cougar/linux/pkg-tools/deb2cross2rpm<BR>
<BR>
I don't know if it works, but it looks OK. I think if you invoke it<BR>
without arguments it just silently exits, but it that's what you =
want<BR>
it to do, then that's OK too.<BR>
<BR>
-- Yea, I need to add a usage message and exit when there are no =
args.<BR>
-- Musta forgot that...<BR>
<BR>
&gt; Global makefiles<BR>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR>
&gt; /homes/larrys/perforce/trees/cougar/nfx-tree/Tools/defs.mk<BR>
<BR>
I don't think this is ready yet.&nbsp; We should sit down and discuss =
the<BR>
overall plan for the Makefiles and includes and stuff.&nbsp; I just want =
to<BR>
hear what you have in mind and so forth.&nbsp; I'm not clear on where =
this<BR>
file fits in and at what stages and so forth.&nbsp; And I'm not too =
thrilled<BR>
with the massive number of ifdefs (ifeqs in makefiles).<BR>
<BR>
-- My changes are not that much to this file. This is an Onstor =
Original,<BR>
-- 90% of what you are looking at is legacy.<BR>
-- I have been talking to Jeff about splitting this file apart. =
Making<BR>
-- massive design changes to this file has always been risky since<BR>
-- everything uses it, even the prom builds use it, so I am told.<BR>
<BR>
&gt; =
/homes/larrys/perforce/trees/cougar/nfx-tree/Tools/tool-chain-pkg.mk<BR>
<BR>
Fill in the first TODO ~:^)<BR>
<BR>
I think you're getting there, or maybe you're already there, but =
let's<BR>
sit down (stand up?) tomorrow and you can run me through this stuff =
a<BR>
little bit before you check it in if that's OK.&nbsp; Tomorrow morning =
is<BR>
fine if that works for you. Maybe grab a room with a whiteboard.<BR>
<BR>
Line 59 has trailing whitespace.<BR>
<BR>
I just want to make sure that I understand the large strokes of the<BR>
overall flow of the design, and what stage we think we're in and =
what<BR>
direction we're going to be going in as things progress.<BR>
<BR>
-- Ok, I need to see what tomorrow brings, but maybe we can do a<BR>
-- whiteboard talk before lunch.<BR>
<BR>
Cheers,<BR>
<BR>
a<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C77B11.6D825398--
