X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7829B.100AEB23@onstor-exch02.onstor.net>; Thu, 19 Apr 2007 08:54:50 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Thu, 19 Apr 2007 08:54:50 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0351BC45@onstor-exch02.onstor.net>
In-Reply-To: <20070418174503.23b0e555@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AceCG/f+h26gwS6KRIq6tNggySPVjgAff4ZQ
References: <BB375AF679D4A34E9CA8DFA650E2B04E032A6A27@onstor-exch02.onstor.net><20070405141235.508a5be7@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E032A6A40@onstor-exch02.onstor.net><20070418163503.24a3dab5@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E0351BA33@onstor-exch02.onstor.net> <20070418174503.23b0e555@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is not an exception.

If they don't belong, get rid of them all together, and fix any code
as necessary. this isn't just an exercise in porting code but a time to
clean things up.  The best thing is to axe this include file, and see
what code stops compiling.  Probably very little?

Alternatively, you could just have these files be in the include list
only on BSD makes.  That's probably the least effort method.

I thought you wrote all this code?  ~:^)  But seriously, this is pretty
messed up.
[MK]=20
Not all this code. Anyway, I moved it to a different directory.


Well then, are you keeping a list of things you're definitely going to
go back and fix?  BTW, it's not harder than I think.  If it was easy,
we would have given the job to Jon.

Are you saying it was originally inline?  Again, this is our big
opportunity to make things better.  It's only a few key strokes, and we
all know how fast you type.
[MK]=20
I do and it is just too messed up to fix together with other things.
Take a look at code/sm-event/emrs-api.h.=20

>      in which the list of files to compile is defined.  so if linux
> has one or two more or one or two less source files, the respective
>      list of source files would be defined in the included makefile,
>      like linux.mk, openbsd.mk, etc.
> MK> I don't think building a library with an empty list of files
> MK> works.

hmm.  i don't get it.  why would it be empty?
[MK] Because fgetln is in standard library for bsd and the bsd
compatibility library for bsd has empty contents.

> nfx-tree/code/ssc-bsdcompat/openbsd.h
>=20
>      ditto for this essentially empty file as well
> MK> Seems to be necessary, otherwise you'll get an error on missing
> include file when doing '#include OS_INCL'

hmm

> nfx-tree/code/ssc-nfxnis/nfxdns-openbsd.c
>=20
>      line 729 is whitespace, and looks like a bug to me.  and why one
> should
>      always use curly braces, even for one line.
>=20
> MK> Right. Go tell this to BSD guys. Doesn't look like a bug, just
> messed up indentation.

but you're the BSD guy.  isn't this our code?
[MK] Not anymore. And this is not our code. It was copy/pasted from the
BSD resolver library and hacked a little bit. Somehow it lost the
copyright notice in the process.


> nfx-tree/code/ssc-nfxnis/openbsd/resolv-internal.h
>=20
>      err, empty file?  no-no.  unless it will eventually get stuff in
> it.
> MK> What's the problem with empty files? I can put a copyright notice
> there, this will make it non-empty.

the answer to this question is not immediately coming to mind.  i just
know we shouldn't have any.  any ideas?


[MK] Nothing comes to mind right away.=20

MK> Some is, but it will require additional effort to separate it.
> Starting from the assumption that none is portable is safe.

throw it on the list.  what is vserver-ipm anyway?
[MK]=20
Something that messes with the kernel to create/delete network
interfaces when the virtual servers are enabled/disabled.

