X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C78217.FFB238B9@onstor-exch02.onstor.net>; Wed, 18 Apr 2007 17:16:38 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Wed, 18 Apr 2007 17:16:38 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0351BA33@onstor-exch02.onstor.net>
In-Reply-To: <20070418163503.24a3dab5@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AceCEjBbM5gx8Z3BSPKch6fIeUfvrAAAHGgQ
References: <BB375AF679D4A34E9CA8DFA650E2B04E032A6A27@onstor-exch02.onstor.net><20070405141235.508a5be7@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E032A6A40@onstor-exch02.onstor.net> <20070418163503.24a3dab5@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

inux/include/net/neteee/eee.h

     line 37, you changed the values here, but the comment still
mentions
     arbitrary values.  should the comment be updated (and r. beck
removed).

MK> OK

nfx-tree/Includes/rpc/rpc.h

     line 57 ifdef.  i thought you fixed all ifdefs.

nfx-tree/Includes/rpc/xdr.h

     line 54 ifdef

MK> Let's make an exception on those two. This is so messed up that I
don't know how to fix it, who in there right mind would define the
includes that match the system include files


nfx-tree/Tools/defs.mk

     line 324, comment should be "if bobcat-linux"

MK> OK


nfx-tree/code/sm-event/linux.h

     geez, at least do the work of making it a C file, as I suspect this
     function is called in many places.  we don't want to make it an
inline.

MK> One thing at a time, OK? This is harder than you think - why would
the person who wrote this code make it inline instead of doing the right
thing?

nfx-tree/code/sm-event/openbsd.h

     ditto with the inline.  isn't this function called a lot?
MK> See above.=20


nfx-tree/code/ssc-bsdcompat/openbsd-fgetln.c

     uh, this file is empty.  no empty files.

     just have the makefile include local OS variants of an include
file,
     in which the list of files to compile is defined.  so if linux has
     one or two more or one or two less source files, the respective
     list of source files would be defined in the included makefile,
     like linux.mk, openbsd.mk, etc.
MK> I don't think building a library with an empty list of files works.

nfx-tree/code/ssc-bsdcompat/openbsd.h

     ditto for this essentially empty file as well
MK> Seems to be necessary, otherwise you'll get an error on missing
include file when doing '#include OS_INCL'

nfx-tree/code/ssc-cluster/Makefile

     looks good


nfx-tree/code/ssc-cluster/openbsd.h

     no empty files.  hmm, actually, maybe it's ok since inevitably
something
     will go in here.

     but no DOS format files, please.  that goes for all your files.

nfx-tree/code/ssc-nfxnis/Makefile

     i think i covered this one in other comments
MK> Covered what?


nfx-tree/code/ssc-nfxnis/nfxdns-openbsd.c

     line 729 is whitespace, and looks like a bug to me.  and why one
should
     always use curly braces, even for one line.

MK> Right. Go tell this to BSD guys. Doesn't look like a bug, just
messed up indentation.

nfx-tree/code/ssc-nfxnis/nfxnis.c

     line 676, what is wrong with isblank?
MK> does not compile.=20

nfx-tree/code/ssc-nfxnis/openbsd/resolv-internal.h

     err, empty file?  no-no.  unless it will eventually get stuff in
it.
MK> What's the problem with empty files? I can put a copyright notice
there, this will make it non-empty.


nfx-tree/code/ssc-openafs-lwp/process.S

     line 18, forbidden ifdef
MK> Let's leave this one for a while. I am not sure that this is=20


nfx-tree/code/ssc-pm/Makefile

     line 66, illegal ifdef
OK

nfx-tree/code/ssc-pm/linux.c

     line 57, 81 whitespace
OK

nfx-tree/code/ssc-pm/openbsd.c

     line 102, 111 113, whitespace

OK

nfx-tree/code/ssc-vsd/vs-ipm-openbsd.c

     gar, bombarded by whitespace!  think of the disk space you'll save.

     but seriously, well, i was already, but seriously, none of this
code
     is portable?
MK> Some is, but it will require additional effort to separate it.
Starting from the assumption that none is portable is safe.


