X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C776DB.D3E7E573@onstor-exch02.onstor.net>; Wed, 4 Apr 2007 10:08:12 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: cougar porting: ifdefs really ARE the devil!
Date: Wed, 4 Apr 2007 10:08:12 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E031DF302@onstor-exch02.onstor.net>
In-Reply-To: <20070403201931.17db2acb@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: cougar porting: ifdefs really ARE the devil!
Thread-Index: Acd2aA/ZrxptLCUIQVWLt9vKnra+8QAESBQw
References: <20070403201931.17db2acb@ripper.onstor.net>
From: "Brian DeForest" <brian.deforest@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>,
	<dl-cougar>,
	<dl-software>

Currently our open source code changes do not use a common ifdef.    We
should pick one (NFX?  ONSTOR?) and be consistent across the board.  =20

We also need to make a golden rule:  if you change any lines of open
source, it gets ifdef'ed.   This is essential.  Failure to comply should
be punishable by <fill in>. =20

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, April 03, 2007 8:20 PM
To: dl-cougar; dl-software
Subject: cougar porting: ifdefs really ARE the devil!

Howdy folks,

Well, the ifdef thing has gotten out of the bag already.  It's my fault,
really.

Having gone through this before, and knowing where the dragons be, I
will write up a cookbook on how to handle them.  So don't panic, give
me a couple of days to whack that out before trying to tackle 'em.
Many of you are not there yet, so you aren't going to be tackling them
in the next day or so anyway.

General rules:

Read my lips*: no new ifdefs allowed.  Exceptions _might_ be: ifdefs for
compiler differences (ssc code at least will be using gcc-4.1.2-ish,
really a prerelease of 4.2; hopefully we can get NFX code onto at
least the latest sde compiler); and ifdefs not introduced by hand
but by running configure in an open source package that we have to break
apart and modify.  That's it.  Seriously.  Finito.

This generally goes for makefiles too.  I'll try to cover that briefly
as well.

Cheers,

a



*spoken by a Bush
