X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C776D8.7FD42D13@onstor-exch02.onstor.net>; Wed, 4 Apr 2007 09:44:23 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Wed, 4 Apr 2007 09:44:29 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E031DF2C9@onstor-exch02.onstor.net>
In-Reply-To: <20070403195844.27526159@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: Acd2ZSin/HLwPdCTT3if73e5m7uJDgAZjoRg
References: <BB375AF679D4A34E9CA8DFA650E2B04E031DE995@onstor-exch02.onstor.net> <20070403195844.27526159@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

> -----Original Message-----
> From: Andy Sharp
> Sent: Tuesday, April 03, 2007 7:59 PM
> To: Maxim Kozlovsky
> Subject: Re: Please review
>=20
> On Mon, 2 Apr 2007 16:41:49 -0700 "Maxim Kozlovsky"
> <maxim.kozlovsky@onstor.com> wrote:
>=20
> >
> > ~/cg/nfx-tree
> >
> > SSC compilation fixes, mostly one-liners. I've ifdefed out the
places
> > that do not compile or will not work on linux without substantial
> > changes.
>=20
> No ifdefs allowed.  Sole exception: ifdefs added by configure in open
> source packages.
>=20
>=20
*** I understand your sentiments about ifdefs, however I am not trying
to fix it all in the first pass. I'd like to get most of the code
compiling so we would be able split the work between more people and
then do it in prettier way.=20

>=20
> > //depot/cougar/nfx-tree/Includes/nfx-defs.h#2 - edit default change
> > (text)
>=20
> wong place for the protocol defs.  should be in one of the eee header
> files.  one that will work in both user and kernel spaces.

Right, so tell me which one.

> > //depot/cougar/nfx-tree/Includes/rpc/rpc.h#1 - edit default change
> > (text)
>=20
> no ifdefs
>=20
See ***

> > //depot/cougar/nfx-tree/Includes/rpc/xdr.h#1 - edit default change
> > (text)
>=20
> no ifdefs

See ***
>=20
> > //depot/cougar/nfx-tree/Makefile.ssc#1 - edit default change (text)
>=20

ok

>=20
> > //depot/cougar/nfx-tree/Tools/defs.mk#3 - edit default change (text)
>=20
> no sync'd with repository
> -Wno-pointer-sign -- are you sure??  we don't want our pointers sign
> extended?  ok then, if you're sure.  just resolve first.

This is not pointer sign extension, this is a warning about conversion
between (unsigned char *) and (char *) which is new in 4.1 gcc. We have
too much code that has this problem.

>=20
> > //depot/cougar/nfx-tree/Tools/suffix.mk#1 - edit default change
(text)
>=20
> changes don't look portable to me
ok

>=20
>=20
> > //depot/cougar/nfx-tree/code/sm-cifs/winerror.h#1 - edit default
> > change (xtext)
>=20
> please put platform stuff in a separate file.  is this platform or
> compiler thing?  or glibc thing?  a compiler thing can stay, but not a
> glibc or platform thing.

Where is the platform stuff?

>=20
> > //depot/cougar/nfx-tree/code/sm-event/emrs-api.h#1 - edit default
> > change (text)
>=20
> lose the ifdefs

See ***
>=20
>=20
>=20
> > //depot/cougar/nfx-tree/code/sm-fs/fs-primitive.h#1 - edit default
> > change (text)
>=20
> this one is just disturbing.  we have our own typedef of noreturn?  i
> don't know what to say.

Old gcc did not have noreturn.=20
>=20
> > //depot/cougar/nfx-tree/code/sm-opt/fs.c#1 - edit default change
>=20
> no ifdefs

See ***
>=20
> > (text) //depot/cougar/nfx-tree/code/sm-opt/opt-api.c#1 - edit
default
> > change (text)
>=20
> no ifdefs

See ***
>=20
>=20
> > //depot/cougar/nfx-tree/code/sm-sct/taskmgr.c#1 - edit default
change
> > (text)
>=20
> what's this 13 crap?  do you mean '\r'?.  who can maintain this?  not
> me, i'm too stupid to know what 13 is all about.

Yeah, right, I can never remember those char codes.=20

>=20
> > //depot/cougar/nfx-tree/code/ssc-authentication/Makefile#1 - edit
> > default change (text)
>=20
> what happened to lic?  not portable (?)

Is not used, does not compile, does not work.=20
>=20
> > //depot/cougar/nfx-tree/code/ssc-authentication/auth-nis.c#1 - edit
> > default change (text)
>=20
> all ok except the ifndef linux -- this can be done in a portable way
>=20
What is the portable way?

>=20
> > //depot/cougar/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#1 -
edit
> > default change (text)
>=20
> agck!  a million horrible ifdefs!

See ***
>=20
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxauth.c#1 - edit default
> > change (text)
>=20
> no ifdefs.  no ifndefs either.
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxdns-inlines.h#1 - edit
> > default change (text)
>=20
> no ifdefs no how
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxdns.c#1 - edit default
> > change (text)
>=20
> definitely not doing this.  no ifdefs like this.  i need to write a
> cookbook so people know what to do.
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxldap.c#1 - edit default
> > change (text)
>=20
> no ifdefs
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-api.h#1 - edit
default
> > change (text)
>=20
> no changes, please revert
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-dns.c#1 - edit
default
> > change (text)
>=20
> lose the ifdef
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-lib.c#1 - edit
default
> > change (text)
>=20
> ok
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-nis.c#1 - edit
default
> > change (text)
>=20
> no ifdefs
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-res.c#1 - edit
default
> > change (text)
>=20
> h_errno?? you're going to have to explain that one.
> no ifdefs
> 2565 do the delorean boys know about this one?
>=20
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-rpc.h#1 - edit
default
> > change (text)
>=20
> i don't like the ifndef, really.  but i might be casual about this
> one.  platform stuff like this should really be in separate files
but...
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-yp.c#1 - edit default
> > change (text)
>=20
> ok
>=20
> > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis.c#1 - edit default
> > change (text)
>=20
> ifdef city.  additions of the casts look ok.  but not the ifdefs.


See *** for all the above. This code needs to be extensively modified
and it is not possible to fix it all at once.

>=20
> > //depot/cougar/nfx-tree/code/ssc-openafs-lwp/process.S#1 - edit
> > default change (text)
>=20
> no ifdefs

See ***
>=20
>=20
> > //depot/cougar/nfx-tree/code/ssc-rmc/rmc_client.c#1 - edit default
> > change (text)
>=20
> no ifdefs, and besides, there is a portable way to do this
>=20
What is it?
>=20
> > //depot/cougar/nfx-tree/code/ssc-vsd/vs-ipm.c#1 - edit default
change
> > (text)
>=20
> no ifdefs, no siree

See ***

