X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C77576.AEC5F683@onstor-exch02.onstor.net>; Mon, 2 Apr 2007 15:31:40 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: code reviewr request: one line change to cmd_flash.c; TED00018217
Date: Mon, 2 Apr 2007 15:31:55 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E031DE907@onstor-exch02.onstor.net>
In-Reply-To: <20070402140829.32de7ee0@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: code reviewr request: one line change to cmd_flash.c; TED00018217
Thread-Index: Acd1axAx4z+90GPMSQu3+vx3TLWsqwAC6WBw
References: <20070402140829.32de7ee0@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

ok

-----Original Message-----
From: Andy Sharp=20
Sent: Monday, April 02, 2007 2:08 PM
To: Maxim Kozlovsky
Subject: code reviewr request: one line change to cmd_flash.c;
TED00018217

TED00018217:

Bunch of extraneous garbage spews out during various nfxsh commands:

system vers -s
read fields=3D3 fdev=3D'/dev/wd1a', fdir=3D'/', ftype=3D'ffs'
read fields=3D3 fdev=3D'/dev/wd1e', fdir=3D'/tmp', ftype=3D'ffs'
read fields=3D3 fdev=3D'/dev/wd1d', fdir=3D'/usr', ftype=3D'ffs'
read fields=3D3 fdev=3D'/dev/wd1g', fdir=3D'/usr/local/agile', =
ftype=3D'ffs'
read fields=3D3 fdev=3D'/dev/wd1f', fdir=3D'/var', ftype=3D'ffs'
read fields=3D3 fdev=3D'/dev/wd1h', fdir=3D'/usr/local/agile/conf',
ftype=3D'ffs'
read fields=3D-1 fdev=3D'/dev/wd1h', fdir=3D'/usr/local/agile/conf',
ftype=3D'ffs'
fields=3D-1, ftype=3D'ffs'
mount_secondary: fs_file=3D/, fs_vfstype=3Dffs, fs_spec=3D/dev/wd1a
mount_secondary: fs_file=3D/tmp, fs_vfstype=3Dffs, fs_spec=3D/dev/wd1e
mount_secondary: fs_file=3D/usr, fs_vfstype=3Dffs, fs_spec=3D/dev/wd1d
mount_secondary: fs_file=3D/usr/local/agile, fs_vfstype=3Dffs,
fs_spec=3D/dev/wd1g
mount_secondary: fs_file=3D/var, fs_vfstype=3Dffs, fs_spec=3D/dev/wd1f
mount_secondary: fs_file=3D/usr/local/agile/conf, fs_vfstype=3Dffs,
fs_spec=3D/dev/wd1h
2.3.0.0


This is debug output that was supposed to be disabled before checkin.
The fix is to remove the hardcoded definition of DEBUG macro from the .c

p4 diff nfx-tree/code/ssc-nfxsh/cmd_flash.c
=3D=3D=3D=3D //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#5 -
/homes/andys/src/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c =
=3D=3D=3D=3D
88,89d87
< #define DEBUG 1
<=20
