X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C770CC.B6DECF29@onstor-exch02.onstor.net>; Tue, 27 Mar 2007 17:04:54 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Request for code review openbsd files
Date: Tue, 27 Mar 2007 17:04:54 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E022156C6@onstor-exch02.onstor.net>
In-Reply-To: <20070327165330.743e6402@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Request for code review openbsd files
Thread-Index: Acdwyx7hHf1poV1PRvmlyFlfaYgV9wAATUng
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

>> Shouldn't this ifndef NOMAN go before the gzip.info line above?
No the gzip.info: rule is the rule building the file not installing it.=20
I only want to conditionally turn off the installation of gzip.info.

L.

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, March 27, 2007 4:54 PM
To: Larry Scheer
Subject: Re: Request for code review openbsd files

On Tue, 27 Mar 2007 16:50:36 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>    Will you review my changes to openbsd files and if you approve I
> will check them in.
>=20
> File # 1 openbsd/stc/etc/mtree/4.4BSD.dist
> Removed empty directyory: /usr/local/info from etc/mtree/4.4BSD.dist
> so it doesn't get created on the filer any more:
>=20
> =3D=3D=3D=3D //depot/FB-DELOREAN/openbsd/src/etc/mtree/4.4BSD.dist#7 -
>
/home/larrys/perforce/trees/FB-DELOREAN/openbsd/src/etc/mtree/4.4BSD.dis
> t =3D=3D=3D=3D
> @@ -520,11 +520,6 @@
>  # ./usr/local/sbin
>  ..
> =20
> -# ./usr/local/info
> -info
> -# ./usr/local/info
> -..
> -
>  # ./usr/local/agile
>  agile
>=20
> File # 2 openbsd/src/gnu/usr.bin/gzip/Makefile=20
> Turned off installing gzip.info=20
>=20
> perforce/trees/FB-DELOREAN/openbsd/src/gnu/usr.bin/gzip/Makefile =
=3D=3D=3D=3D
> @@ -1,6 +1,9 @@
>  #      $OpenBSD: Makefile,v 1.12 1999/02/25 04:24:28 millert Exp $
>  #      $NetBSD: Makefile,v 1.17 1995/10/24 22:18:34 jtc Exp $
> =20
> +# ONStor change, Don't build man pages or install gzip.info
> +NOMAN=3D 1
> +
>  PROG=3D  gzip
>  SRCS=3D  gzip.c zip.c deflate.c trees.c bits.c unzip.c inflate.c
> util.c \ crypt.c lzw.c unlzw.c unlzh.c unpack.c getopt.c
> @@ -36,9 +39,11 @@
>  gzip.info:     gzip.texi
>         ${MAKEINFO} -I${.CURDIR} ${.CURDIR}/gzip.texi
> =20
> +.ifndef NOMAN

Shouldn't this ifndef NOMAN go before the gzip.info line above?

>  beforeinstall:
>         ${INSTALL} ${INSTALL_COPY} -m 444 -o ${BINOWN} -g ${BINGRP}
> *.info* \
>                 ${DESTDIR}/usr/share/info
> +.endif
> =20
>  afterinstall:
>         install -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
>=20
