X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C770B2.99B3EE26@onstor-exch02.onstor.net>; Tue, 27 Mar 2007 13:57:58 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: code review for CF upgrades
Date: Tue, 27 Mar 2007 13:56:36 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E03086106@onstor-exch02.onstor.net>
In-Reply-To: <20070327114052.1af1c812@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: code review for CF upgrades
Thread-Index: Acdwn3JjPPnadUQgQxW6ACb8yZyKYwAAXlvQ
References: <20070327114052.1af1c812@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Make sure you run this as non-root user, it is hard to track if you have
become_root()/unbecome_root() in all the right places.

22: mkpath was literally copied from some bsd utility, hence the
copyright.

97: comment the global variable

122: use the common comment format in (at least) the new routines, see
sm-cifs/ for examples.=20

152, 306: Use ensure_fs_writable()/restore_fs_permissions() instead of
assuming the fs mounted readonly

199: why swap should be 6%?

476: Does not unmount on failure

576: Should make sure that /mnt1 exists, since the code below does not
handle the intermediate components of the path missing.

766: Ignoring the error but still printing the error message. This can
be confusing.

971: could you change the order, there is a block of code down couple of
line which does !error check. This caused a brain lock for few moments
while trying to look at both fragments together.

980: Check for error?



-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, March 27, 2007 11:41 AM
To: Maxim Kozlovsky
Subject: code review for CF upgrades

Hi Max,

Please review the file nfx-tree/code/ssc-nfxsh/cmd_flash.c from
perforce changelist 23271 on client `ripper'.  Larry is reviewing the
rest of the files, so you don't need to review the others from the
changelist, but hey you can if you want ~:^)

Thanks,

a
