X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C76CCD.5CF96582@onstor-exch02.onstor.net>; Thu, 22 Mar 2007 14:59:28 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C76CCD.5CF96582"
References: <BB375AF679D4A34E9CA8DFA650E2B04E022156AE@onstor-exch02.onstor.net> <20070322134403.248e8376@ripper.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E02F3CDA3@onstor-exch02.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E02F12B97@onstor-exch02.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 23229 for review
Date: Thu, 22 Mar 2007 14:58:43 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E02F3CDA4@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 23229 for review
Thread-Index: AcdswtOfR6VfT8HrTuejJr/eMUw9mgAAE9w2AAEfgWAAAWhIFg==
From: "Ken Renshaw" <ken.renshaw@onstor.com>
To: "Tim Gardner" <tim.gardner@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>,
	"Larry Scheer" <larry.scheer@onstor.com>
Cc: "Jonathan Goldick" <jonathan.goldick@onstor.com>,
	"Brian DeForest" <brian.deforest@onstor.com>,
	"Charissa Willard" <charissa.willard@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C76CCD.5CF96582
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Done deal, here's the current list of rules, and feel free to have me =
add others:
=20
[perforce@liszt perforce]$ p4 triggers -o
# Perforce Pre-Submit Trigger Specifications.
#
#  Triggers:    a list of triggers; one per line.  Each line has three
#               elements:
#
#               Name:   The name of the trigger.
#
#               Path:   Files which cause the trigger to be run.
#
#               Command: The command to run to validate the changelist.
#                        If the command contains spaces, the whole =
command
#                        must be quoted.  See 'p4 help trigger' for a =
list
#                        of variables that can be expanded in the =
command
#                        string.
#
#  For example,
#
#       Triggers:
#               example //... "runcommand %changelist%"
#
# See 'p4 help triggers' for more information about triggers.
Triggers:
        Reviewed_By_Field_Not_Self1 //depot/.../*.c =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self2 //depot/.../*.h =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self3 //depot/.../*.js =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self4 //depot/.../*.S =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self5 //depot/.../Makefile* =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self6 //depot/.../*.mk =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self7 //depot/nfx-test/.../*.pl =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self8 //depot/nfx-test/.../*.java =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self9 //depot/nfx-test/.../*.sh =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"
        Reviewed_By_Field_Not_Self10 //depot/nfx-test/.../*.vbs =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% %user%"


________________________________

From: Tim Gardner
Sent: Thu 3/22/2007 2:18 PM
To: Ken Renshaw; Andy Sharp; Larry Scheer
Cc: Jonathan Goldick; Brian DeForest; Charissa Willard
Subject: RE: PERFORCE change 23229 for review



I agree that these files should also be reviewed.

-----Original Message-----
From: Ken Renshaw
Sent: Thursday, March 22, 2007 1:46 PM
To: Andy Sharp; Larry Scheer
Cc: Tim Gardner; Jonathan Goldick; Brian DeForest; Charissa Willard
Subject: RE: PERFORCE change 23229 for review

Sure Andy, i can add the new types in a few keystrokes. Tim/Brian, I =
assume it's okay to add the following filetypes for the Reviewed By =
precommit trigger:

.js
.S
Makefile*
*.mk

Any others?

Given quick consensus I'll add these this afternoon, thanks Andy.

-Ken


-----Original Message-----
From: Andy Sharp
Sent: Thu 3/22/2007 1:44 PM
To: Larry Scheer
Cc: Ken Renshaw; Tim Gardner; Jonathan Goldick
Subject: Re: PERFORCE change 23229 for review

Ken, Larry,

Can we change this please?  Shouldn't be too difficult, should it?  To
reiterate from a previous email thread, I think all changes to
makefiles and .js files and .S files and .sh files and .mk files should
be added to the review pre-checkin trigger.  My point is that either
the review process makes sense or it doesn't.  If it does, then we
should be doing it for all these files and maybe a few others that I
can't think of at the moment.

a



On Thu, 22 Mar 2007 13:03:14 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>       JFYI, I forgot to add Charissa as the reviewer on this change
> list.
> P4 doesn't check for reviewers if there are no .c or .h files in the
> change list.
>
> -----Original Message-----
> From: Larry Scheer
> Sent: Thursday, March 22, 2007 1:01 PM
> To: Andy Sharp; Brian DeForest; Charissa Willard; Chris Vandever;
> Danqing Jin; Henry Lau; Ian Brown; Jeseem S; Jobi Ariyamannil;
> Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim Kozlovsky; Nagendra
> Subramanya; Sandrine Boulanger; Tim Gardner
> Subject: PERFORCE change 23229 for review
>
> Change 23229 by larrys@larrys-verify-depot on 2007/03/22 11:47:48
>
>       Fixes for incremental builds over NFS. The help.sh script
> wasn't able
>       to overwrite web/js/help.js. Also the user was being prompted
> to rename
>       files that previously existed.
>
> Affected files ...
>
> ... //depot/FB-DELOREAN/nfx-tree/Tools/suffix.mk#8 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-webui/help.sh#7 edit
>




------_=_NextPart_001_01C76CCD.5CF96582
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<HTML dir=3Dltr><HEAD><TITLE>RE: PERFORCE change 23229 for review</TITLE>=0A=
<META http-equiv=3DContent-Type content=3D"text/html; charset=3Dunicode">=0A=
<META content=3D"MSHTML 6.00.5730.11" name=3DGENERATOR></HEAD>=0A=
<BODY>=0A=
<DIV id=3DidOWAReplyText97026 dir=3Dltr>=0A=
<DIV dir=3Dltr><FONT face=3DArial color=3D#000000 size=3D2>Done deal, =
here's the current list of rules, and feel free to have me add =
others:</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>[perforce@liszt perforce]$ p4 =
triggers -o<BR># Perforce Pre-Submit Trigger =
Specifications.<BR>#<BR>#&nbsp; Triggers:&nbsp;&nbsp;&nbsp; a list of =
triggers; one per line.&nbsp; Each line has =
three<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp; =
elements:<BR>#<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Name:&nbsp;&nbsp; The name of the =
trigger.<BR>#<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Path:&nbsp;&nbsp; Files which cause the =
trigger to be =
run.<BR>#<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
;&nbsp;&nbsp;&nbsp;&nbsp; Command: The command to run to validate the =
changelist.<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp; If the command contains spaces, the whole =
command<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp; must be quoted.&nbsp; See 'p4 help trigger' for a =
list<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
; of variables that can be expanded in the =
command<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp; string.<BR>#<BR>#&nbsp; For =
example,<BR>#<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Triggers:<BR>#&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
;&nbsp;&nbsp;&nbsp;&nbsp; example //... "runcommand =
%changelist%"<BR>#<BR># See 'p4 help triggers' for more information =
about triggers.</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial =
size=3D2>Triggers:<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self1 //depot/.../*.c =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self2 //depot/.../*.h =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self3 //depot/.../*.js =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self4 //depot/.../*.S =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self5 //depot/.../Makefile* =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self6 //depot/.../*.mk =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self7 //depot/nfx-test/.../*.pl =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self8 //depot/nfx-test/.../*.java =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self9 //depot/nfx-test/.../*.sh =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Reviewed_By_Field_Not_Self10 //depot/nfx-test/.../*.vbs =
"/perforce/trees/cm/p4_scripts/p4trigger2.sh %changelist% =
%user%"<BR></FONT></DIV></DIV>=0A=
<DIV dir=3Dltr><BR>=0A=
<HR tabIndex=3D-1>=0A=
<FONT face=3DTahoma size=3D2><B>From:</B> Tim Gardner<BR><B>Sent:</B> =
Thu 3/22/2007 2:18 PM<BR><B>To:</B> Ken Renshaw; Andy Sharp; Larry =
Scheer<BR><B>Cc:</B> Jonathan Goldick; Brian DeForest; Charissa =
Willard<BR><B>Subject:</B> RE: PERFORCE change 23229 for =
review<BR></FONT><BR></DIV>=0A=
<DIV>=0A=
<P><FONT size=3D2>I agree that these files should also be =
reviewed.<BR><BR>-----Original Message-----<BR>From: Ken =
Renshaw<BR>Sent: Thursday, March 22, 2007 1:46 PM<BR>To: Andy Sharp; =
Larry Scheer<BR>Cc: Tim Gardner; Jonathan Goldick; Brian DeForest; =
Charissa Willard<BR>Subject: RE: PERFORCE change 23229 for =
review<BR><BR>Sure Andy, i can add the new types in a few keystrokes. =
Tim/Brian, I assume it's okay to add the following filetypes for the =
Reviewed By precommit =
trigger:<BR><BR>.js<BR>.S<BR>Makefile*<BR>*.mk<BR><BR>Any =
others?<BR><BR>Given quick consensus I'll add these this afternoon, =
thanks Andy.<BR><BR>-Ken<BR><BR><BR>-----Original Message-----<BR>From: =
Andy Sharp<BR>Sent: Thu 3/22/2007 1:44 PM<BR>To: Larry Scheer<BR>Cc: Ken =
Renshaw; Tim Gardner; Jonathan Goldick<BR>Subject: Re: PERFORCE change =
23229 for review<BR><BR>Ken, Larry,<BR><BR>Can we change this =
please?&nbsp; Shouldn't be too difficult, should it?&nbsp; =
To<BR>reiterate from a previous email thread, I think all changes =
to<BR>makefiles and .js files and .S files and .sh files and .mk files =
should<BR>be added to the review pre-checkin trigger.&nbsp; My point is =
that either<BR>the review process makes sense or it doesn't.&nbsp; If it =
does, then we<BR>should be doing it for all these files and maybe a few =
others that I<BR>can't think of at the =
moment.<BR><BR>a<BR><BR><BR><BR>On Thu, 22 Mar 2007 13:03:14 -0700 =
"Larry Scheer"<BR>&lt;larry.scheer@onstor.com&gt; wrote:<BR><BR>&gt; =
Andy,<BR>&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp; JFYI, I forgot to add =
Charissa as the reviewer on this change<BR>&gt; list.<BR>&gt; P4 doesn't =
check for reviewers if there are no .c or .h files in the<BR>&gt; change =
list.<BR>&gt;<BR>&gt; -----Original Message-----<BR>&gt; From: Larry =
Scheer<BR>&gt; Sent: Thursday, March 22, 2007 1:01 PM<BR>&gt; To: Andy =
Sharp; Brian DeForest; Charissa Willard; Chris Vandever;<BR>&gt; Danqing =
Jin; Henry Lau; Ian Brown; Jeseem S; Jobi Ariyamannil;<BR>&gt; Jonathan =
Goldick; Ken Renshaw; Larry Scheer; Maxim Kozlovsky; Nagendra<BR>&gt; =
Subramanya; Sandrine Boulanger; Tim Gardner<BR>&gt; Subject: PERFORCE =
change 23229 for review<BR>&gt;<BR>&gt; Change 23229 by =
larrys@larrys-verify-depot on 2007/03/22 11:47:48<BR>&gt;<BR>&gt; =
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Fixes for incremental builds over NFS. =
The help.sh script<BR>&gt; wasn't able<BR>&gt; =
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; to overwrite web/js/help.js. Also the =
user was being prompted<BR>&gt; to rename<BR>&gt; =
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; files that previously =
existed.<BR>&gt;<BR>&gt; Affected files ...<BR>&gt;<BR>&gt; ... =
//depot/FB-DELOREAN/nfx-tree/Tools/suffix.mk#8 edit<BR>&gt; ... =
//depot/FB-DELOREAN/nfx-tree/code/ssc-webui/help.sh#7 =
edit<BR>&gt;<BR><BR></FONT></P></DIV></BODY></HTML>
------_=_NextPart_001_01C76CCD.5CF96582--
