X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C76CC5.877B563D@onstor-exch02.onstor.net>; Thu, 22 Mar 2007 14:03:24 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 23229 for review
Date: Thu, 22 Mar 2007 14:03:23 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E02F12B5D@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02F3CDA3@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 23229 for review
Thread-Index: AcdswtOfR6VfT8HrTuejJr/eMUw9mgAAE9w2AACVEAA=
References: <BB375AF679D4A34E9CA8DFA650E2B04E022156AE@onstor-exch02.onstor.net> <20070322134403.248e8376@ripper.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E02F3CDA3@onstor-exch02.onstor.net>
From: "Brian DeForest" <brian.deforest@onstor.com>
To: "Ken Renshaw" <ken.renshaw@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>,
	"Larry Scheer" <larry.scheer@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>,
	"Jonathan Goldick" <jonathan.goldick@onstor.com>,
	"Charissa Willard" <charissa.willard@onstor.com>

I completely agree.    Thanks Andy.

-----Original Message-----
From: Ken Renshaw=20
Sent: Thursday, March 22, 2007 1:46 PM
To: Andy Sharp; Larry Scheer
Cc: Tim Gardner; Jonathan Goldick; Brian DeForest; Charissa Willard
Subject: RE: PERFORCE change 23229 for review

Sure Andy, i can add the new types in a few keystrokes. Tim/Brian, I
assume it's okay to add the following filetypes for the Reviewed By
precommit trigger:

.js
.S
Makefile*
*.mk

Any others?

Given quick consensus I'll add these this afternoon, thanks Andy.

-Ken


-----Original Message-----
From: Andy Sharp
Sent: Thu 3/22/2007 1:44 PM
To: Larry Scheer
Cc: Ken Renshaw; Tim Gardner; Jonathan Goldick
Subject: Re: PERFORCE change 23229 for review
=20
Ken, Larry,

Can we change this please?  Shouldn't be too difficult, should it?  To
reiterate from a previous email thread, I think all changes to
makefiles and .js files and .S files and .sh files and .mk files should
be added to the review pre-checkin trigger.  My point is that either
the review process makes sense or it doesn't.  If it does, then we
should be doing it for all these files and maybe a few others that I
can't think of at the moment.

a



On Thu, 22 Mar 2007 13:03:14 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
> 	JFYI, I forgot to add Charissa as the reviewer on this change
> list.
> P4 doesn't check for reviewers if there are no .c or .h files in the
> change list.
>=20
> -----Original Message-----
> From: Larry Scheer=20
> Sent: Thursday, March 22, 2007 1:01 PM
> To: Andy Sharp; Brian DeForest; Charissa Willard; Chris Vandever;
> Danqing Jin; Henry Lau; Ian Brown; Jeseem S; Jobi Ariyamannil;
> Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim Kozlovsky; Nagendra
> Subramanya; Sandrine Boulanger; Tim Gardner
> Subject: PERFORCE change 23229 for review
>=20
> Change 23229 by larrys@larrys-verify-depot on 2007/03/22 11:47:48
>=20
> 	Fixes for incremental builds over NFS. The help.sh script
> wasn't able
> 	to overwrite web/js/help.js. Also the user was being prompted
> to rename
> 	files that previously existed.
>=20
> Affected files ...
>=20
> ... //depot/FB-DELOREAN/nfx-tree/Tools/suffix.mk#8 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-webui/help.sh#7 edit
>=20

