X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C76CC3.C9D95036@onstor-exch02.onstor.net>; Thu, 22 Mar 2007 13:50:56 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C76CC3.C9D95036"
References: <BB375AF679D4A34E9CA8DFA650E2B04E022156AE@onstor-exch02.onstor.net> <20070322134403.248e8376@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 23229 for review
Date: Thu, 22 Mar 2007 13:46:16 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E02F3CDA3@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 23229 for review
Thread-Index: AcdswtOfR6VfT8HrTuejJr/eMUw9mgAAE9w2
From: "Ken Renshaw" <ken.renshaw@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>,
	"Larry Scheer" <larry.scheer@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>,
	"Jonathan Goldick" <jonathan.goldick@onstor.com>,
	"Brian DeForest" <brian.deforest@onstor.com>,
	"Charissa Willard" <charissa.willard@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C76CC3.C9D95036
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Sure Andy, i can add the new types in a few keystrokes. Tim/Brian, I =
assume it's okay to add the following filetypes for the Reviewed By =
precommit trigger:

.js
.S
Makefile*
*.mk

Any others?

Given quick consensus I'll add these this afternoon, thanks Andy.

-Ken


-----Original Message-----
From: Andy Sharp
Sent: Thu 3/22/2007 1:44 PM
To: Larry Scheer
Cc: Ken Renshaw; Tim Gardner; Jonathan Goldick
Subject: Re: PERFORCE change 23229 for review
=20
Ken, Larry,

Can we change this please?  Shouldn't be too difficult, should it?  To
reiterate from a previous email thread, I think all changes to
makefiles and .js files and .S files and .sh files and .mk files should
be added to the review pre-checkin trigger.  My point is that either
the review process makes sense or it doesn't.  If it does, then we
should be doing it for all these files and maybe a few others that I
can't think of at the moment.

a



On Thu, 22 Mar 2007 13:03:14 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
> 	JFYI, I forgot to add Charissa as the reviewer on this change
> list.
> P4 doesn't check for reviewers if there are no .c or .h files in the
> change list.
>=20
> -----Original Message-----
> From: Larry Scheer=20
> Sent: Thursday, March 22, 2007 1:01 PM
> To: Andy Sharp; Brian DeForest; Charissa Willard; Chris Vandever;
> Danqing Jin; Henry Lau; Ian Brown; Jeseem S; Jobi Ariyamannil;
> Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim Kozlovsky; Nagendra
> Subramanya; Sandrine Boulanger; Tim Gardner
> Subject: PERFORCE change 23229 for review
>=20
> Change 23229 by larrys@larrys-verify-depot on 2007/03/22 11:47:48
>=20
> 	Fixes for incremental builds over NFS. The help.sh script
> wasn't able
> 	to overwrite web/js/help.js. Also the user was being prompted
> to rename
> 	files that previously existed.
>=20
> Affected files ...
>=20
> ... //depot/FB-DELOREAN/nfx-tree/Tools/suffix.mk#8 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-webui/help.sh#7 edit
>=20


------_=_NextPart_001_01C76CC3.C9D95036
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7652.24">
<TITLE>RE: PERFORCE change 23229 for review</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>Sure Andy, i can add the new types in a few =
keystrokes. Tim/Brian, I assume it's okay to add the following filetypes =
for the Reviewed By precommit trigger:<BR>
<BR>
.js<BR>
.S<BR>
Makefile*<BR>
*.mk<BR>
<BR>
Any others?<BR>
<BR>
Given quick consensus I'll add these this afternoon, thanks Andy.<BR>
<BR>
-Ken<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Thu 3/22/2007 1:44 PM<BR>
To: Larry Scheer<BR>
Cc: Ken Renshaw; Tim Gardner; Jonathan Goldick<BR>
Subject: Re: PERFORCE change 23229 for review<BR>
<BR>
Ken, Larry,<BR>
<BR>
Can we change this please?&nbsp; Shouldn't be too difficult, should =
it?&nbsp; To<BR>
reiterate from a previous email thread, I think all changes to<BR>
makefiles and .js files and .S files and .sh files and .mk files =
should<BR>
be added to the review pre-checkin trigger.&nbsp; My point is that =
either<BR>
the review process makes sense or it doesn't.&nbsp; If it does, then =
we<BR>
should be doing it for all these files and maybe a few others that I<BR>
can't think of at the moment.<BR>
<BR>
a<BR>
<BR>
<BR>
<BR>
On Thu, 22 Mar 2007 13:03:14 -0700 &quot;Larry Scheer&quot;<BR>
&lt;larry.scheer@onstor.com&gt; wrote:<BR>
<BR>
&gt; Andy,<BR>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp; JFYI, I forgot to add Charissa as =
the reviewer on this change<BR>
&gt; list.<BR>
&gt; P4 doesn't check for reviewers if there are no .c or .h files in =
the<BR>
&gt; change list.<BR>
&gt;<BR>
&gt; -----Original Message-----<BR>
&gt; From: Larry Scheer<BR>
&gt; Sent: Thursday, March 22, 2007 1:01 PM<BR>
&gt; To: Andy Sharp; Brian DeForest; Charissa Willard; Chris =
Vandever;<BR>
&gt; Danqing Jin; Henry Lau; Ian Brown; Jeseem S; Jobi Ariyamannil;<BR>
&gt; Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim Kozlovsky; =
Nagendra<BR>
&gt; Subramanya; Sandrine Boulanger; Tim Gardner<BR>
&gt; Subject: PERFORCE change 23229 for review<BR>
&gt;<BR>
&gt; Change 23229 by larrys@larrys-verify-depot on 2007/03/22 =
11:47:48<BR>
&gt;<BR>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Fixes for incremental builds over =
NFS. The help.sh script<BR>
&gt; wasn't able<BR>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp; to overwrite web/js/help.js. Also =
the user was being prompted<BR>
&gt; to rename<BR>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp; files that previously existed.<BR>
&gt;<BR>
&gt; Affected files ...<BR>
&gt;<BR>
&gt; ... //depot/FB-DELOREAN/nfx-tree/Tools/suffix.mk#8 edit<BR>
&gt; ... //depot/FB-DELOREAN/nfx-tree/code/ssc-webui/help.sh#7 edit<BR>
&gt;<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C76CC3.C9D95036--
