X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C76057.D1A1C2AD@onstor-exch02.onstor.net>; Tue, 6 Mar 2007 18:27:49 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C76057.D1A1C2AD"
Content-class: urn:content-classes:message
Subject: RE: please review code change for TED 17992
Date: Tue, 6 Mar 2007 18:27:52 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E02B74EBB@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02B74EB0@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review code change for TED 17992
Thread-Index: AcdgV3+x6V2DJvwzToaT+bwNYMw9kQAAB5Ow
References: <BB375AF679D4A34E9CA8DFA650E2B04E02B74EB0@onstor-exch02.onstor.net>
From: "Brian DeForest" <brian.deforest@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Cc: "Larry Scheer" <larry.scheer@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C76057.D1A1C2AD
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Ed, I need to leave early and will be offline for a while.   Larry or
Andy, can one of you review this for Ed?

_____________________________________________
From: Ed Kwan=20
Sent: Tuesday, March 06, 2007 5:26 PM
To: Brian DeForest
Subject: please review code change for TED 17992

Hi Brian,

Client name: edk-delorean
File: openbsd/src/sys/kern/uipc_usrreq.c

My change is based on the following change in OpenBSD:

Revision 1.29
<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?rev=3D1=
.
29&content-type=3Dtext/x-cvsweb-markup>  / (download
<http://www.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/kern/uipc_usrr
eq.c?rev=3D1.29&content-type=3Dtext/plain> ) - annotate
<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?annota
te=3D1.29>  - [select for diffs]
<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?r1=3D1.=
2
9>  , Tue May 17 21:43:08 2005 UTC (21 months, 2 weeks ago) by fgsch=20
Branch: MAIN
<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?only_w
ith_tag=3DMAIN> =20
CVS Tags: OPENBSD_3_8_BASE
<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?only_w
ith_tag=3DOPENBSD_3_8_BASE> =20
Branch point for: OPENBSD_3_8
<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?only_w
ith_tag=3DOPENBSD_3_8> =20
Changes since 1.28: +3 -1 lines
Diff to previous 1.28
<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c.diff?r
1=3D1.28&r2=3D1.29>  (colored
<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c.diff?r
1=3D1.28&r2=3D1.29&f=3Dh> )=20
under some circunstances, unp_scan() can call unp_mark() with a null
pointer,
so check fp before dereferencing it; fixes a crash found by hshoexer@
with input from art@, art@ millert@ deraadt@ ok.


Thanks,
Ed



------_=_NextPart_001_01C76057.D1A1C2AD
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Dus-ascii">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7652.24">
<TITLE>RE: please review code change for TED 17992</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/rtf format -->

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
COLOR=3D"#000080" SIZE=3D2 FACE=3D"Arial">Ed, I need to leave early and =
will be offline for a while.&nbsp;&nbsp; Larry</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"> <FONT COLOR=3D"#000080" =
SIZE=3D2 FACE=3D"Arial">or Andy, can one of you review this for =
Ed?</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D2 =
FACE=3D"Tahoma">_____________________________________________<BR>
</FONT></SPAN><SPAN LANG=3D"en-us"><B></B></SPAN><SPAN =
LANG=3D"en-us"><B><FONT SIZE=3D2 =
FACE=3D"Tahoma">From:</FONT></B></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Tahoma"> Ed Kwan<BR>
</FONT></SPAN><SPAN LANG=3D"en-us"><B></B></SPAN><SPAN =
LANG=3D"en-us"><B><FONT SIZE=3D2 =
FACE=3D"Tahoma">Sent:</FONT></B></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Tahoma"> Tuesday, March 06, 2007 =
5:26 PM<BR>
</FONT></SPAN><SPAN LANG=3D"en-us"><B></B></SPAN><SPAN =
LANG=3D"en-us"><B><FONT SIZE=3D2 =
FACE=3D"Tahoma">To:</FONT></B></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Tahoma"> Brian DeForest<BR>
</FONT></SPAN><SPAN LANG=3D"en-us"><B></B></SPAN><SPAN =
LANG=3D"en-us"><B><FONT SIZE=3D2 =
FACE=3D"Tahoma">Subject:</FONT></B></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Tahoma"> please review code change for TED =
17992</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D2 FACE=3D"Arial">Hi Brian,</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Client =
name: edk-delorean</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">File: =
openbsd/src/sys/kern/uipc_usrreq.c</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">My =
change is based on the following change in OpenBSD:</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us">Revision </SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?=
rev=3D1.29&amp;content-type=3Dtext/x-cvsweb-markup"><SPAN =
LANG=3D"en-us"><B><U><FONT =
COLOR=3D"#0000FF">1.29</FONT></U></B></SPAN><SPAN =
LANG=3D"en-us"></SPAN></A><SPAN LANG=3D"en-us"> / (</SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/kern/uip=
c_usrreq.c?rev=3D1.29&amp;content-type=3Dtext/plain"><SPAN =
LANG=3D"en-us"><B><U><FONT =
COLOR=3D"#0000FF">download</FONT></U></B></SPAN><SPAN =
LANG=3D"en-us"></SPAN></A><SPAN LANG=3D"en-us">) - </SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?=
annotate=3D1.29"><SPAN LANG=3D"en-us"><U><FONT =
COLOR=3D"#0000FF">annotate</FONT></U></SPAN><SPAN =
LANG=3D"en-us"></SPAN></A><SPAN LANG=3D"en-us"> - </SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?=
r1=3D1.29"><SPAN LANG=3D"en-us"><U><FONT COLOR=3D"#0000FF">[select for =
diffs]</FONT></U></SPAN><SPAN LANG=3D"en-us"></SPAN></A><SPAN =
LANG=3D"en-us"> ,<I> Tue May 17 21:43:08 2005 UTC</I> (<FONT =
COLOR=3D"#00AA00">21 months, 2 weeks</FONT></SPAN><SPAN LANG=3D"en-us"> =
ago) by<I> fgsch</I><BR>
Branch: </SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?=
only_with_tag=3DMAIN"><SPAN LANG=3D"en-us"><B><U><FONT =
COLOR=3D"#0000FF">MAIN</FONT></U></B></SPAN><SPAN =
LANG=3D"en-us"></SPAN></A><SPAN LANG=3D"en-us"><B></B><BR>
CVS Tags: </SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?=
only_with_tag=3DOPENBSD_3_8_BASE"><SPAN LANG=3D"en-us"><B><U><FONT =
COLOR=3D"#0000FF">OPENBSD_3_8_BASE</FONT></U></B></SPAN><SPAN =
LANG=3D"en-us"></SPAN></A><SPAN LANG=3D"en-us"><B></B><BR>
Branch point for: </SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?=
only_with_tag=3DOPENBSD_3_8"><SPAN LANG=3D"en-us"><B><U><FONT =
COLOR=3D"#0000FF">OPENBSD_3_8</FONT></U></B></SPAN><SPAN =
LANG=3D"en-us"></SPAN></A><SPAN LANG=3D"en-us"><B></B><BR>
Changes since<B> 1.28: +3 -1 lines</B><BR>
Diff to previous </SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c.=
diff?r1=3D1.28&amp;r2=3D1.29"><SPAN LANG=3D"en-us"><U><FONT =
COLOR=3D"#0000FF">1.28</FONT></U></SPAN><SPAN =
LANG=3D"en-us"></SPAN></A><SPAN LANG=3D"en-us"> (</SPAN><A =
HREF=3D"http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c.=
diff?r1=3D1.28&amp;r2=3D1.29&amp;f=3Dh"><SPAN LANG=3D"en-us"><U><FONT =
COLOR=3D"#0000FF">colored</FONT></U></SPAN><SPAN =
LANG=3D"en-us"></SPAN></A><SPAN LANG=3D"en-us">) </SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT COLOR=3D"#000000" =
SIZE=3D2 FACE=3D"Courier New">under some circunstances, unp_scan() can =
call unp_mark() with a null pointer,</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT COLOR=3D"#000000" SIZE=3D2 =
FACE=3D"Courier New">so check fp before dereferencing it; fixes a crash =
found by hshoexer@</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT COLOR=3D"#000000" SIZE=3D2 =
FACE=3D"Courier New">with input from art@, art@ millert@ deraadt@ =
ok.</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">Thanks,</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">Ed</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

</BODY>
</HTML>
------_=_NextPart_001_01C76057.D1A1C2AD--
