X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C75B9F.5B145DC9@onstor-exch02.onstor.net>; Wed, 28 Feb 2007 18:17:18 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 22893 for review
Date: Wed, 28 Feb 2007 18:17:18 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E02A086EE@onstor-exch02.onstor.net>
In-Reply-To: <20070228162231.2999bdc9@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 22893 for review
Thread-Index: Acdbl7O5j4YJH677RJmwC1XEs7w7DAABxZNw
References: <WEBMAILK5qL0WphVf7i00000d43@mail.onstor.com><BB375AF679D4A34E9CA8DFA650E2B04E02A08647@onstor-exch02.onstor.net> <20070228162231.2999bdc9@ripper.onstor.net>
From: "Brian DeForest" <brian.deforest@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>

Maybe I'm missing something.   Isn't the fact that a code change was
needed so it will not be "silently excluded" the same as supporting it?
Put another way, without your change, how is it "silently excluded"?

The bottom line is that whenever possible, we would like QA to validate
code changes.

I'm not trying to be a pain in the a** or create more work.   If I don't
ask, QA most likely will, so I thought I was doing you a favor...   :-)


-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, February 28, 2007 4:23 PM
To: Brian DeForest
Cc: Tim Gardner
Subject: Re: PERFORCE change 22893 for review

Generally speaking, yes, but I was of the impression that checkins
aren't being restricted as of yet for things that don't require QA
testing.  We aren't going to explicitly state support for the Iceweasel
version of Firefox, but I would like it to silently not be excluded.  No
QA testing is needed for Iceweasel over and above Firefox since they are
one and the same.

Right now I can't access filers that are not running with this change,
so it's posing a problem for me.  I realize I'm on the leading edge of
some things but that's a good thing in this case as this might start to
bite some of our customers at around the time Delorean starts to make it
into the field.  Especially if Fedora adopts the Iceweasel name as well.

a


On Wed, 28 Feb 2007 16:02:12 -0800 "Brian DeForest"
<brian.deforest@onstor.com> wrote:

> A more descriptive description is desirable... =20
>=20
> Having looked at the code, I see you added support for Iceweasel.
> Please file a defect for this so QA can test it and properly close it.
> Generally speaking, whenever possible the related defect # should be=20
> referenced in the changelist.
>=20
> Thanks.
> Brian
>=20
> -----Original Message-----
> From: Andy Sharp
> Sent: Wednesday, February 28, 2007 11:46 AM
> To: Andy Sharp; Brian DeForest; Charissa Willard; Chris Vandever;=20
> Danqing Jin; Henry Lau; Ian Brown; Jeseem S; Jobi Ariyamannil;=20
> Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim Kozlovsky; Nagendra

> Subramanya; Sandrine Boulanger; Tim Gardner
> Subject: PERFORCE change 22893 for review
>=20
> Change 22893 by andys@ripper on 2007/02/28 11:36:40
>=20
> 	Free friends of firefox.
> 	Reviewed by charissaw
>=20
> Affected files ...
>=20
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-webui/js/console/login.js#4
> edit
>=20
