X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C734D7.3AA9E4A0@onstor-exch02.onstor.net>; Wed, 10 Jan 2007 08:49:01 -0800
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C734D7.3AA9E4A0"
Content-class: urn:content-classes:message
Subject: Looks like a patch to upgrade fixed the corruption problem with cmd_upgrade.c when using /usr/bin/install
Date: Wed, 10 Jan 2007 08:49:01 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0A90FB@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Looks like a patch to upgrade fixed the corruption problem with cmd_upgrade.c when using /usr/bin/install
thread-index: Acc0zHJYkXxdGeXRQTW54bxMlYsPnw==
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>,
	"Jay Michlin" <jay.michlin@onstor.com>,
	"Tim Gardner" <tim.gardner@onstor.com>
Cc: "Larry Scheer" <larry.scheer@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C734D7.3AA9E4A0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Good news folks!
   Yesterday Andy compared xinstall.c (the source for /usr/bin/install) =
to the code for the cp command and came up with a 3 line patch to make =
install behave more like cp. I applied this patch to the latest version =
of xinstall.c which I upgraded yesterday. The patch turns off a block of =
code that is similar to what is found in /bin/cp and is also turned off. =
So far, it looks like this patch works!=20

Thanks Andy for finding this fix! I owe you a beer or two.

I ran my test cases last night and they all passed with no file =
corruption being detected. Previously I was seeing corrupted files in =
10% of the iterations through the tests.

One other piece of news, I have a script that replaces the =
normal/typical workflow of nfxsh upgrade. I used it to successfully =
recover my filer which was trashed when the power went out in the lab =
last night. The power was dropped while I was in the middle of a nfxsh =
upgrade of the primary flash. (Are you smiling or laughing Andy? ;-)=20

I propose offering this script to QA and CS as "the workaround" to the =
upgrade issues in the field. I think this script gives them what they =
have been asking for.

Some details about the script:

The script's default function is to verify the integrity of files on a =
system by using a manifest file. It also has the option to recover files =
that don't match the source distribution. To recover files it uses a =
similar methodology used by cmd_upgrade with one main exception.Instead =
of using /usr/bin/install it uses /bin/cp. This script also has the =
option to use an install method I want to incorporate into Delorean. =
This method consumes far less memory and solves one of the three main =
defects with the current upgrade program. I can provide details for =
anyone who wants more information.

If CS and QA aren't interested in the script I can use it as a =
proof-of-concept for the upgrade overhaul planned for the Delorean =
release.

Larry


------_=_NextPart_001_01C734D7.3AA9E4A0
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7650.28">
<TITLE>Looks like a patch to upgrade fixed the corruption problem with =
cmd_upgrade.c when using /usr/bin/install</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>Good news folks!<BR>
&nbsp;&nbsp; Yesterday Andy compared xinstall.c (the source for =
/usr/bin/install) to the code for the cp command and came up with a 3 =
line patch to make install behave more like cp. I applied this patch to =
the latest version of xinstall.c which I upgraded yesterday. The patch =
turns off a block of code that is similar to what is found in /bin/cp =
and is also turned off. So far, it looks like this patch works!<BR>
<BR>
Thanks Andy for finding this fix! I owe you a beer or two.<BR>
<BR>
I ran my test cases last night and they all passed with no file =
corruption being detected. Previously I was seeing corrupted files in =
10% of the iterations through the tests.<BR>
<BR>
One other piece of news, I have a script that replaces the =
normal/typical workflow of nfxsh upgrade. I used it to successfully =
recover my filer which was trashed when the power went out in the lab =
last night. The power was dropped while I was in the middle of a nfxsh =
upgrade of the primary flash. (Are you smiling or laughing Andy? ;-)<BR>
<BR>
I propose offering this script to QA and CS as &quot;the =
workaround&quot; to the upgrade issues in the field. I think this script =
gives them what they have been asking for.<BR>
<BR>
Some details about the script:<BR>
<BR>
The script's default function is to verify the integrity of files on a =
system by using a manifest file. It also has the option to recover files =
that don't match the source distribution. To recover files it uses a =
similar methodology used by cmd_upgrade with one main exception.Instead =
of using /usr/bin/install it uses /bin/cp. This script also has the =
option to use an install method I want to incorporate into Delorean. =
This method consumes far less memory and solves one of the three main =
defects with the current upgrade program. I can provide details for =
anyone who wants more information.<BR>
<BR>
If CS and QA aren't interested in the script I can use it as a =
proof-of-concept for the upgrade overhaul planned for the Delorean =
release.<BR>
<BR>
Larry<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C734D7.3AA9E4A0--
