X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7551F.E056B366@onstor-exch02.onstor.net>; Tue, 20 Feb 2007 11:49:39 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C7551F.E056B366"
Content-class: urn:content-classes:message
Subject: unit testing and code reviews
Date: Tue, 20 Feb 2007 11:49:38 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E027C240C@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: unit testing and code reviews
Thread-Index: AcdVH9+54xh8bbB6RTWqd/L5+4tc6Q==
From: "Brian DeForest" <brian.deforest@onstor.com>
To: "dl-Software" <dl-software@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C7551F.E056B366
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Just a friendly reminder to remember to make a "best effort" to unit
test code prior to checking in.    One responsibility of the code
reviewer is to check what unit tests have been performed and determine
what, if any, additional regression testing may be needed.
=20
There have been a few crashes and assertions hit almost immediately in
the past few Delorean builds.  Subsequent patches were required.   On a
positive note, the turnaround time for implementing the fixes and
patched builds has been quick (often the same day).   On a negative
note, it would be preferable not to have to do the patches in the first
place.   Obviously, this is not completely avoidable, and everyone
generally does make a "best effort" to checkin high quality, well tested
code.   So again, just consider this a friendly reminder...
=20
Thanks.
Brian

------_=_NextPart_001_01C7551F.E056B366
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=3DContent-Type content=3D"text/html; =
charset=3Dus-ascii">
<META content=3D"MSHTML 6.00.2900.3020" name=3DGENERATOR></HEAD>
<BODY>
<DIV><SPAN class=3D957262818-20022007><FONT face=3DArial size=3D2>Just a =
friendly=20
reminder to remember to make&nbsp;a "best effort" to unit test code =
prior to=20
checking in.&nbsp;&nbsp;&nbsp; One responsibility of the code reviewer =
is to=20
check what unit tests have been performed and determine&nbsp;what, if=20
any,&nbsp;additional regression testing&nbsp;may=20
be&nbsp;needed.</FONT></SPAN></DIV>
<DIV><SPAN class=3D957262818-20022007><FONT face=3DArial=20
size=3D2></FONT></SPAN>&nbsp;</DIV>
<DIV><SPAN class=3D957262818-20022007><FONT face=3DArial size=3D2>There =
have been a=20
few crashes and assertions hit almost immediately in the&nbsp;past few =
Delorean=20
builds.&nbsp; Subsequent patches were required.&nbsp;&nbsp; On a =
positive note,=20
the turnaround time for implementing the fixes and patched builds has =
been quick=20
(often the same day).&nbsp;&nbsp; On a negative note, it would be =
preferable not=20
to have to do the patches in the first place.&nbsp;&nbsp; Obviously, =
this is not=20
completely avoidable, and everyone generally does make a "best effort" =
to=20
checkin high quality, well tested code.&nbsp;&nbsp; So again, just =
consider this=20
a friendly reminder...</FONT></SPAN></DIV>
<DIV><SPAN class=3D957262818-20022007><FONT face=3DArial=20
size=3D2></FONT></SPAN>&nbsp;</DIV>
<DIV><SPAN class=3D957262818-20022007><FONT face=3DArial=20
size=3D2>Thanks.<BR>Brian</FONT></SPAN></DIV></BODY></HTML>

------_=_NextPart_001_01C7551F.E056B366--
