X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7E520.C8B52732@onstor-exch02.onstor.net>; Wed, 22 Aug 2007 16:58:57 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: the Zonda FOTW (fix of the week) award goes to...
Date: Wed, 22 Aug 2007 16:58:56 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E051AED94@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: the Zonda FOTW (fix of the week) award goes to...
Thread-Index: AcflB7oA9jINyZgfTWyi/w3XKJk2iAAEsnxQ
From: "Brian DeForest" <brian.deforest@onstor.com>
To: "dl-Software" <dl-software@onstor.com>
Cc: "Paul Hammer" <paul.hammer@onstor.com>

...Rendell for fixing 2 major memory leaks, with some additional help
from dmalloc (and his partner in crime, Jim). =20

This was a case where extensive code inspection AND Coverity were
insufficient, and instrumenting the code with dmalloc was necessary to
isolate the leaks. =20

Ron previously received a FOTW award for a memory leak fix in Samba
(also detected by dmalloc). Ron gets the added bonus of checking in the
dmalloc code (with a README) when he returns from vacation... :-)  We'll
want to leverage this for all apps/libraries going forward.

Every release is getting significantly more stable.   Good work guys!

Brian
-----Original Message-----
From: Rendell Fong=20
Sent: Wednesday, August 22, 2007 3:00 PM
To: Amit Bothra; Andy Sharp; Brian DeForest; Charissa Willard; Chris
Vandever; Danqing Jin; Deepak Veliath; Henry Lau; Ian Brown; Jobi
Ariyamannil; Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim
Kozlovsky; Mike Lee; Sandrine Boulanger; Tim Gardner
Subject: PERFORCE change 25126 for review

Change 25126 by rendellf@rendellf on 2007/08/22 14:50:34

	Fixed memory leaks in spm and ncm api.  These leaks were causing
spm to lose
	528 bytes per ncm_send() call (sync send case) or once per 20
sec polling
	cycle at minimum.  Loss of memory was even greater when a rescan
for devices
	occurred.
	   Reviewed By: JamesK
	   REGRESSION: Verify that memory usage by spm doesn't
continually increase
	               over time.

Affected files ...

... //depot/dev/nfx-tree/code/sm-spm/spm-msg.c#3 edit
... //depot/dev/nfx-tree/code/ssc-ncm-lib/ncm-api.c#2 edit


http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/25126?ac=3D10
