X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7E4FF.CD883DA6@onstor-exch02.onstor.net>; Wed, 22 Aug 2007 13:02:51 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: pleeze review
Date: Wed, 22 Aug 2007 13:02:51 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E051AEC32@onstor-exch02.onstor.net>
In-Reply-To: <20070822133943.32a19c20@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: pleeze review
Thread-Index: Acfk/JIDz/G7pXHPTumrPTstIxV9uwAAiWEg
References: <20070822133943.32a19c20@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>



>-----Original Message-----
>From: Andy Sharp
>Sent: Wednesday, August 22, 2007 1:40 PM
>To: Maxim Kozlovsky
>Subject: pleeze review
>
>Change 25125 by andys@ripper on 2007/08/22 11:05:06 *pending*
>
>        Some kernel updates before cougar changes come in.
>
>        Add a touch of locking to the driver on the TX side; and some
>        TX drain control to the mpsc console tx routine in an attempt
>        to fix console lockup problem.  Might be helping, but console
>        still locks up sometimes.
>
>        Make the ide-cs hacks more benign in regards to cougar which
>        won't need them.
>
>Affected files ...
>
>...
//depot/dev/linux/kernel/linux-mips-2.6/drivers/ide/legacy/ide-cs.c#2
>edit
[MK]=20
Ok

>... //depot/dev/linux/kernel/linux-mips-2.6/drivers/serial/mpsc.c#1
edit
[MK]=20
554: why change, the registers are 4 byte wide.

1118,1221: I have no idea what low_latency means and why does it matter
but ok.

1752: This is going to deadlock with itself.

I am curious, why you are adding spinlock for tx but no spinlock for rx?


