X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7E02D.67055F29@onstor-exch02.onstor.net>; Thu, 16 Aug 2007 09:46:40 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Thu, 16 Aug 2007 09:46:40 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0507D9E9@onstor-exch02.onstor.net>
In-Reply-To: <20070816104251.29ee41f2@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcfgLN5V6p+X5NzOTcyZ0YJKpJ82jgAAB7sQ
References: <BB375AF679D4A34E9CA8DFA650E2B04E0507D9A7@onstor-exch02.onstor.net> <20070816104251.29ee41f2@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>


>-----Original Message-----
>From: Andy Sharp
>Sent: Thursday, August 16, 2007 10:43 AM
>To: Maxim Kozlovsky
>Subject: Re: Please review
>
>On Thu, 16 Aug 2007 10:17:10 -0700 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>> Change 25046 by maximk@maximk-5 on 2007/08/16 10:11:55 *pending*
>>
>>            fix interface commands for linux.
>>            Reviewed by andys.
>>
>> Affected files ...
>>
>> ... //depot/dev/nfx-tree/Includes/eee/ipm-if.h#1 add
>> ... //depot/dev/nfx-tree/Includes/nfx-ports.h#1 edit
>> ... //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c#2 edit
>
>nfx-tree/Includes/eee/ipm-if.h
>
>     >>add nfx-tree/Includes/eee/ipm-if.h
>
>     sc?  can't we switch to a meaningful name?  how about mgmt?  mgt?
[MK]=20
I suppose we could, but it is not that easy (the upgrade may be tricky)
and is out of scope of the current project. At least during the cougar
work we will get all references in the code to be done through #defines
instead of direct strings. Can you live with your hate for a while?=20
>
>     i hate sc.  i would use eth, but that's also a little too system
>     specific.
>
>     what do you think?  i'd love to get these openbsd device names out
>     of our system, out of our GUI interface, etc.
>
>nfx-tree/Includes/nfx-ports.h
>
>     looks good
>
>nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c
>
>     looks good

