X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7DF68.CE9D357C@onstor-exch02.onstor.net>; Wed, 15 Aug 2007 10:19:23 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Wed, 15 Aug 2007 10:19:23 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E04FA81F7@onstor-exch02.onstor.net>
In-Reply-To: <20070815111451.2f1b6fcb@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcffaC2ClrpFC8ucQKeB5DrpUodoywAABnhg
References: <BB375AF679D4A34E9CA8DFA650E2B04E04FA8156@onstor-exch02.onstor.net> <20070815111451.2f1b6fcb@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

>-----Original Message-----
>From: Andy Sharp
>Sent: Wednesday, August 15, 2007 11:15 AM
>To: Maxim Kozlovsky
>Subject: Re: Please review
>
>On Wed, 15 Aug 2007 10:19:20 -0700 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>> Change 25021 by maximk@maximk-5 on 2007/08/15 10:13:37 *pending*
>>
>>         Fix segfault when can't open ntp configuration file.
>>            Reviewed by andys.
>>
>> Affected files ...
>>
>> ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils.c#1 edit
>>
>> I have no idea how my name got on this routine.
>>
>>
>
>nfx-tree/code/ssc-timekeeper/ntp_utils.c
>
>     line 128
>
>     sure, sure, we know who wrote it.  too late to erase evidence of
>     blame now.
[MK]  No, really. Have you ever heard me using the word "hosed"? I had
to look it in the dictionary to understand what the comment means.

>
>     while you're here, why not make the routine portable?
>     the ntp package on debian has files in /etc/ntp.conf and
>     /etc/default/ntp.conf
[MK]=20
Yeah, I noticed that this will not work on linux. I am working on that
now.
>
>     not to mention /etc/cron.daily/ntp

