X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7DECF.9C5931CC@onstor-exch02.onstor.net>; Tue, 14 Aug 2007 16:02:46 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Tue, 14 Aug 2007 16:02:46 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E04FA7F2B@onstor-exch02.onstor.net>
In-Reply-To: <20070814170009.54753a56@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: Acfezz65akgCnD5iR0Wpyuussh91HwAADCGQ
References: <BB375AF679D4A34E9CA8DFA650E2B04E04FA7EB9@onstor-exch02.onstor.net><20070814165346.01b32db8@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E04FA7F21@onstor-exch02.onstor.net> <20070814170009.54753a56@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>



>-----Original Message-----
>From: Andy Sharp
>Sent: Tuesday, August 14, 2007 5:00 PM
>To: Maxim Kozlovsky
>Subject: Re: Please review
>
>On Tue, 14 Aug 2007 16:55:59 -0700 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>>
>>
>> >-----Original Message-----
>> >From: Andy Sharp
>> >Sent: Tuesday, August 14, 2007 4:54 PM
>> >To: Maxim Kozlovsky
>> >Subject: Re: Please review
>> >
>> >On Tue, 14 Aug 2007 15:59:54 -0700 "Maxim Kozlovsky"
>> ><maxim.kozlovsky@onstor.com> wrote:
>> >
>> >> Change 25018 by maximk@maximk-13 on 2007/08/14 15:55:01 *pending*
>> >>
>> >>         fix unsigned/signed mismatch
>> >>            Reviewed by andys.
>> >>
>> >> Affected files ...
>> >>
>> >> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils-linux.c#1 edit
>> >>
>> >
>> >yeesh, ugly.  can't you just make line 28
>> >
>> >unsigned long
>> >
>> >instead of long?
>> [MK]
>> This will not help and original gethostid() returns long.
>
>how about
>
>return ((ifr.ifr_hwaddr.sa_data[3] & 0xff) << 8) |
>(ifr.ifr_hwaddr.sa_data[4] & 0xff);
>
>at least that way you don't have 400 parens and no readability.
[MK] This is not readable either, if you need a conversion explicit
conversion better than implicit.=20
