X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7DB8B.11762FBA@onstor-exch02.onstor.net>; Fri, 10 Aug 2007 12:14:34 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Fri, 10 Aug 2007 12:14:33 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E04FA72C7@onstor-exch02.onstor.net>
In-Reply-To: <20070810114257.52a522db@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcfbfkS0LTgV58j+QAmqK4RLBsy70AADLGfQ
References: <BB375AF679D4A34E9CA8DFA650E2B04E04EECE40@onstor-exch02.onstor.net> <20070810114257.52a522db@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>



>-----Original Message-----
>From: Andy Sharp
>Sent: Friday, August 10, 2007 11:43 AM
>To: Maxim Kozlovsky
>Subject: Re: Please review
>
>
>nfx-tree/code/sm-ipmd-lib/ipmd-lib.c
>
>     geez, can't you fix the broken trailing whitespace in your
>     editor program?
>
>     line 2238, the use of truncate here troubles me.  i'd at least
>     like to see another rewind(fp) first.  i'm afraid that a
truncate()
>     here could cause a sparse file because the offset in fp isn't
being
>     reset, so the fwrite would start writing at the current offset.
[MK] Better now?
>
