X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C73126.4F58DC3C@onstor-exch02.onstor.net>; Fri, 5 Jan 2007 16:05:01 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Code review for rc.agile
Date: Fri, 5 Jan 2007 16:05:01 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0A9456@onstor-exch02.onstor.net>
In-Reply-To: <20070105143210.33ac57ec@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Code review for rc.agile
thread-index: AccxGVbdK/iCcxdbRcmD4SexJknibwADN0ug
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Right! Oopps, what was I thinking?

-----Original Message-----
From: Andrew Sharp [mailto:andy.sharp@onstor.com]=20
Sent: Friday, January 05, 2007 2:32 PM
To: Larry Scheer
Subject: Re: Code review for rc.agile

On Fri, 5 Jan 2007 14:20:12 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I am building an image to test as I type!
>=20
> =20
>=20
> Thanks for the review. This is what the script looks like with your
> suggestions incoporated:
>=20
> =20
>=20
> # New Zoneinfo file for DST upgrades installed once at boot time
>=20
> if [ -f /var/tmp/zoneinfo.tgz ] ; then
>=20
>    mount -u -w `df /usr | fgrep /usr | awk '{print $NF}'`

won't work on systems where /usr isn't separately mounted.  try:

df /usr | tail -1 | awk '{print $NF}'

>    tar zxpf /var/tmp/zoneinfo.tgz -C /
>=20
>    if [ -f /usr/share/zoneinfo/America/Kentucky/Louisville ] ; then
>=20
>       rm -f /var/tmp/zoneinfo.tgz
>=20
>       echo "New Time Zone Files for Daylight Savings Time (DST)
> Installed"
>=20
>    fi
>=20
>    mount -u -o ro `df /usr | fgrep /usr | awk '{print $NF}'`
>=20
> fi
>=20
> =20
>=20
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@onstor.com]=20
> Sent: Friday, January 05, 2007 2:17 PM
> To: Larry Scheer
> Subject: Re: Code review for rc.agile
>=20
> =20
>=20
> On Fri, 5 Jan 2007 11:51:32 -0800 Andrew Sharp <andy.sharp@onstor.com>
>=20
> wrote:
>=20
> =20
>=20
> > Basically, it looks OK.
>=20
> >=20
>=20
> > On Thu, 4 Jan 2007 19:24:29 -0800 "Larry Scheer"
>=20
> > <larry.scheer@onstor.com> wrote:
>=20
> >=20
>=20
> > > Andy,
>=20
> > >     Here are my changes to implement the fix for the missing
>=20
> > > timezone files:=20
>=20
> > >=20
>=20
> > > Added to the release target in nfx-tree/Makefile the script to
> > > build
>=20
> > > the tar file  for zoneinfo
>=20
> > >=20
>=20
> > > > # Upgrade is mis-handling zoneinfo files here is part of the
>=20
> > > work-around until
>=20
> > > > # upgrade is fixed
>=20
> > > >       cd ${PATH_TO_RELEASE} && \
>=20
> > > >       $(SUDO) tar zcvf var/zoneinfo.tgz ./usr/share/zoneinfo
>=20
> >=20
>=20
> > Please change the tar file to /var/tmp/zoneinfo.tgz
>=20
> > Don't put things in the top level of /var
>=20
> =20
>=20
> Based on what I can see in cmd_upgrade.c, there should be no problem
>=20
> putting this file in /var/tmp.  It will be treated as a new file and
>=20
> copied onto the system.  Obviously you need to test all this.
>=20
> =20
>=20
> > > The changes to rc.agile:
>=20
> > >=20
>=20
> > > p4 diff rc.agile
>=20
> > > =3D=3D=3D=3D =
//depot/FB-LAMBORGHINI/nfx-tree/code/ssc-pm/rc.agile#3 -
>=20
> > >
>
/home/larrys/perforce/trees/FB-LAMBORGHINI/nfx-tree/code/ssc-pm/rc.agile
>=20
> > > =3D=3D=3D=3D
>=20
> > > 27c27,38
>=20
> > > <=20
>=20
> > > ---
>=20
> > > >=20
>=20
> > > > # New Zoneinfo file for DST upgrades installed once at boot time
>=20
> > > > if [ -f /var/zoneinfo.tgz ] ; then
>=20
> >=20
>=20
> > /var/tmp/zoninfo.tgz
>=20
> >=20
>=20
> > > >    mount -u /usr
>=20
> >=20
>=20
> > mount -u -w /usr
>=20
> >=20
>=20
> > Don't assume that /usr is separately mounted.  Check first to see
> > what
>=20
> > filesystem /usr is on, and do the remounting on that filesystem.
>=20
> >=20
>=20
> > > >    tar zxpf /var/zoneinfo.tgz -C /
>=20
> >=20
>=20
> > /var/tmp
>=20
> >=20
>=20
> > > >    if [ -f /usr/share/zoneinfo/America/Kentucky/Louisville ] ;
>=20
> > > > then rm -f /var/zoneinfo.tgz =20
>=20
> > > >       echo "New Time Zone Files for Daylight Savings Time (DST)
>=20
> > > Installed"
>=20
> > > >    fi
>=20
> >=20
>=20
> > I suppose this specific check is OK for now ... probably not really
>=20
> > necessary, however.
>=20
> >=20
>=20
> > > >    mount -u -o ro /usr
>=20
> >=20
>=20
> > Again, remount the filesystem that has /usr on it, not just
>=20
> > assuming /usr is a separate mount.
>=20
> >=20
>=20
> > > > fi
>=20
> > > >
>=20
> > >=20
>=20
> > > The install places the zoneinfo tar file in the /var directory. At
>=20
> > > boot time if the tar file exists it gets untarred into /usr. The
>=20
> > > check for success is to verify just one (out of many files) of the
>=20
> > > new files is there, if it is the tar file is removed and  this
>=20
> > > segment of the script is never run until the next upgrade places
> > > the
>=20
> > > tar file back in /var.
>=20
> > >=20
>=20
> > > Do you think this is sufficient? Any comments?
>=20
> >=20
>=20
> > Looks good.
>=20
> >=20
>=20
> > Cheers,
>=20
> >=20
>=20
> > a
>=20
