X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C73079.02A58376@onstor-exch02.onstor.net>; Thu, 4 Jan 2007 19:24:29 -0800
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C73079.02A58376"
Content-class: urn:content-classes:message
Subject: Code review for rc.agile
Date: Thu, 4 Jan 2007 19:24:29 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0A9454@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Code review for rc.agile
thread-index: AccweQKxYEKpeYpSSKKcUsAjhp3tvQ==
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C73079.02A58376
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Andy,
    Here are my changes to implement the fix for the missing timezone
files:=20

Added to the release target in nfx-tree/Makefile the script to build the
tar file  for zoneinfo

> # Upgrade is mis-handling zoneinfo files here is part of the
work-around until
> # upgrade is fixed
>       cd ${PATH_TO_RELEASE} && \
>       $(SUDO) tar zcvf var/zoneinfo.tgz ./usr/share/zoneinfo

The changes to rc.agile:

p4 diff rc.agile
=3D=3D=3D=3D //depot/FB-LAMBORGHINI/nfx-tree/code/ssc-pm/rc.agile#3 -
/home/larrys/perforce/trees/FB-LAMBORGHINI/nfx-tree/code/ssc-pm/rc.agile
=3D=3D=3D=3D
27c27,38
<=20
---
>=20
> # New Zoneinfo file for DST upgrades installed once at boot time
> if [ -f /var/zoneinfo.tgz ] ; then
>    mount -u /usr
>    tar zxpf /var/zoneinfo.tgz -C /
>    if [ -f /usr/share/zoneinfo/America/Kentucky/Louisville ] ; then=20
>       rm -f /var/zoneinfo.tgz =20
>       echo "New Time Zone Files for Daylight Savings Time (DST)
Installed"
>    fi
>    mount -u -o ro /usr
> fi
>

The install places the zoneinfo tar file in the /var directory. At boot
time if the tar file exists it gets untarred into /usr. The check for
success is to verify just one (out of many files) of the new files is
there, if it is the tar file is removed and  this segment of the script
is never run until the next upgrade places the tar file back in /var.

Do you think this is sufficient? Any comments?

Larry


------_=_NextPart_001_01C73079.02A58376
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Dus-ascii">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7650.28">
<TITLE>Code review for rc.agile</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/rtf format -->

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">Andy,</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"> <FONT SIZE=3D2 =
FACE=3D"Arial">Here are my changes to</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial"> implement the fix for the missing timezone =
files:</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial"></FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"> </SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Added =
to the release target in nfx-tree/Makefile</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial"> the script to build the tar file&nbsp; for =
zoneinfo</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&gt; =
# Upgrade is mis-handling zoneinfo files here is part of the work-around =
until</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&gt; =
# upgrade is fixed</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; cd =
${PATH_TO_RELEASE} &amp;&amp; \</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $(SUDO) tar zcvf =
var/zoneinfo.tgz ./usr/share/zoneinfo</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">The</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"> <FONT SIZE=3D2 FACE=3D"Arial">changes to =
rc.agile:</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">p4 =
diff rc.agile</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">=3D=3D=3D=3D =
//depot/FB-LAMBORGHINI/nfx-tree/code/ssc-pm/rc.agile#3 - =
/home/larrys/perforce/trees/FB-LAMBORGHINI/nfx-tree/code/ssc-pm/rc.agile =
=3D=3D=3D=3D</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">27c27,38</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&lt; =
</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">---</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&gt; =
</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&gt; =
# New Zoneinfo file for DST upgrades installed once at boot =
time</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&gt; =
if [ -f /var/zoneinfo.tgz ] ; then</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp; mount -u /usr</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp; tar zxpf /var/zoneinfo.tgz -C =
/</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp; if [ -f =
/usr/share/zoneinfo/America/Kentucky/Louisville ] ; then =
</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; rm -f =
/var/zoneinfo.tgz&nbsp; </FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; echo &quot;New =
Time Zone Files for Daylight Savings Time (DST) =
Installed&quot;</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp; fi</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;&nbsp;&nbsp;&nbsp; mount -u -o ro =
/usr</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&gt; =
fi</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&gt;</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">The =
install places the zoneinfo tar file in the /var directory. At boot time =
if the tar file exists it gets untarred into /usr. The check for success =
is to verify just one (out of many files) of the new files is there, if =
it is the tar file is removed and&nbsp; this segment of the script is =
never run until the next upgrade places the tar file back in =
/var.</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Do =
you think this is sufficient? Any comments?</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">Larry</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

</BODY>
</HTML>
------_=_NextPart_001_01C73079.02A58376--
