X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7D84F.FF4D3156@onstor-exch02.onstor.net>; Mon, 6 Aug 2007 09:34:10 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review .2
Date: Mon, 6 Aug 2007 09:34:09 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E04DFA143@onstor-exch02.onstor.net>
In-Reply-To: <20070803191427.086d485a@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review .2
Thread-Index: AcfWPS9+ghYtklQATXW5YAGQBLF+mgCETYJA
References: <BB375AF679D4A34E9CA8DFA650E2B04E04DF9704@onstor-exch02.onstor.net><20070802144254.06909a02@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E04DF971F@onstor-exch02.onstor.net> <20070803191427.086d485a@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

>
>linux/src/glibc-2.3.6.ds1/glibc-2.3.6/include/resolv.h
>
>     hidden protos are always good (?)
>
>linux/src/glibc-2.3.6.ds1/glibc-2.3.6/linuxthreads/sysdeps/pthread/res-
>state.c
>
>     hidden defs even better (??)
[MK]=20

Hidden prototypes prevent redefinition - all calls within libc are
directed to the original function even if the symbol is defined
elsewhere, and I am going to redefine __res_state().

>
>
>nfx-tree/Includes/openbsd/nfxdns-inlines.h
>
>     aiee, this file is in openbsd?  is it used in the linux build of
>     the product?  won't the BSD build still need the locks?
[MK]=20

The locks do not work, that was never tested, and we don't use threads
and will not use them any time soon.=20

>
>nfx-tree/code/ssc-nfxnis/nfxdns-linux.c
>
>     line 28 why not use variable macro?
>     #define debugger(x...) printf(x)
>     then you can do things like this to add the function name and
newline
>and stuff:
>     #define debugu(fmt, args...) \
>     	printf("%s: " fmt "\n", __func__, ##args)
>     cpp automatically handles the case where there is only one
argument
[MK] ok
>
>     line 125 (i think) "name - the database name."	???
[MK] That's what they call the files like /etc/services, /etc/hosts etc.
It is kind of database in some sense.
>
