X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7CEE8.12A8949D@onstor-exch02.onstor.net>; Wed, 25 Jul 2007 10:17:34 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: two reviews
Date: Wed, 25 Jul 2007 10:17:34 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0221590D@onstor-exch02.onstor.net>
In-Reply-To: <20070724212640.11998f01@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: two reviews
Thread-Index: AcfOdABsKpjWFhuCQ76kFm/Lc7rMaQAcpIYw
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I took a fresh look at the Makefile and the piece that bugged me most
was the ROOTFS/NFSROOT section. Getting a warning message because you
are using NFSROOT just doesn't seem right when the default behavior of
the Makefile is to build NFSROOT.=20

That logic is just too dubya.

Later,

Larry=20

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, July 24, 2007 9:27 PM
To: Larry Scheer
Subject: Re: two reviews

We must be looking at 2 different files, but we can take as many cracks
at it as you like.

It builds now without specifying anything, which is one of the things
you were pushing for.  I forget the rest.


On Tue, 24 Jul 2007 19:54:34 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Hey Andy,
>    I am late with this review because I'm just not satisfied with how
> you changed things. I don't see how it is much of an improvement over
> what was there before. (kernel/Makefile)
>=20
> Maybe we need to take another crack at this with clear heads and a
> fresh perspective.
>=20
> Larry
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Friday, July 20, 2007 2:48 PM
> To: Larry Scheer
> Subject: two reviews
>=20
> review #1:
>=20
> This should be good enough for now.  I hope.
>=20
> Change 24647 by andys@ripper on 2007/07/19 16:52:40 *pending*
>=20
>         This may be Northern California, but in this case this is
>         just wrong!  But seriously, fix up the makefile logic a bit
>         to clue people in on what they are supposed to do, as well
>         as set things up for when we have a non NFS root.
>=20
> Affected files ...
>=20
> ... //depot/cougar/linux/kernel/Makefile#4 edit
>=20
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> review #2: you only care about the files NOT in the .git directory.
> So that would be only the first 7 files.
>=20
>=20
>=20
