X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7CE67.21E4999B@onstor-exch02.onstor.net>; Tue, 24 Jul 2007 18:54:34 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: two reviews
Date: Tue, 24 Jul 2007 18:54:34 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0221590B@onstor-exch02.onstor.net>
In-Reply-To: <20070720144733.7c82fe6a@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: two reviews
Thread-Index: AcfLF5RT0bKkq0Q1TbySilVajC6qlgDTuv9Q
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Hey Andy,
   I am late with this review because I'm just not satisfied with how
you changed things. I don't see how it is much of an improvement over
what was there before. (kernel/Makefile)

Maybe we need to take another crack at this with clear heads and a fresh
perspective.

Larry

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, July 20, 2007 2:48 PM
To: Larry Scheer
Subject: two reviews

review #1:

This should be good enough for now.  I hope.

Change 24647 by andys@ripper on 2007/07/19 16:52:40 *pending*

        This may be Northern California, but in this case this is
        just wrong!  But seriously, fix up the makefile logic a bit
        to clue people in on what they are supposed to do, as well
        as set things up for when we have a non NFS root.

Affected files ...

... //depot/cougar/linux/kernel/Makefile#4 edit

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

review #2: you only care about the files NOT in the .git directory.  So
that would be only the first 7 files.



