X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7CE47.8D5F9B4B@onstor-exch02.onstor.net>; Tue, 24 Jul 2007 15:08:31 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 24704 for review
Date: Tue, 24 Jul 2007 15:08:31 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E018A69D0@onstor-exch02.onstor.net>
In-Reply-To: <20070724154805.268139c7@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 24704 for review
Thread-Index: AcfORLLHeDt8evaVQaejfhoyRfXqTwAAnvTw
From: "Jeff Miller" <jeff.miller@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Andy,
I agree with you and I will use more meaningful comments in the future.
Thanks,
Jeff

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, July 24, 2007 3:48 PM
To: Jeff Miller
Subject: Re: PERFORCE change 24704 for review

That's fine for a private convention, but it doesn't help someone else
6-9 months from now who is trying to determine if s/he needs to look at
these changes to see if they have anything to do with .... you see what
I mean.

 On Tue, 24 Jul 2007 15:27:35 -0700 "Jeff Miller"
<jeff.miller@onstor.com> wrote:

> It was stuff like adding comments, not anything that affects the
> compiled code. =20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Tuesday, July 24, 2007 3:21 PM
> To: Jeff Miller
> Subject: Re: PERFORCE change 24704 for review
>=20
> On 24 Jul 2007 15:14:18 -0700 Jeff Miller <jeff.miller@onstor.com>
> wrote:
>=20
> > Change 24704 by jeffm@jeffm-cougar on 2007/07/24 15:07:18
> >=20
> > 	Minor cleanup.
>=20
> Minor cleanup?  Are you going to know what that means six months from
> now?  Please try to be more explicit in the future with checkin
> comments.  Remember: it's a time capsule message to yourself (or
> someone like you) six months from now.
>=20
> Thank you,
>=20
> a
>=20
> > 	Reviewed by: billn
> >=20
> > Affected files ...
> >=20
> > ... //depot/cougar/nfx-tree/code/sm-ispfc/ispfc_nvram.c#3 edit
> > ... //depot/cougar/nfx-tree/code/sm-ispfc/ispfc_scsi.c#5 edit
> > ... //depot/cougar/nfx-tree/code/sm-sanm-dm/sanm-dm-api.h#2 edit
> > ... //depot/cougar/nfx-tree/code/sm-sanm-dm/sanm-dm-private.h#3 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi-api.h#5 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi-disk-cmds.c#2 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi-msg.c#8 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi-tape-cmds.c#3 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi.c#5 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi.h#3 edit
> >=20
> >=20
> > http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/24704?ac=3D10
