X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7CD56.2F5188B3@onstor-exch02.onstor.net>; Mon, 23 Jul 2007 10:20:44 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Mon, 23 Jul 2007 10:20:43 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E049DEB6A@onstor-exch02.onstor.net>
In-Reply-To: <20070723111448.000c5383@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcfNVVsCY383YcUqR9eAM0CE5y+TmgAAIhaQ
References: <BB375AF679D4A34E9CA8DFA650E2B04E049DEAF2@onstor-exch02.onstor.net> <20070723111448.000c5383@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

     line 142, curious, why did you change from 'inline' to '__inline'?

They prefer to use __inline in other places in the kernel. I guess this
provides some independence from different treatment of "inline" by
different compilers.

     line 1385
     i doubt the rest of the file is like this, but in general for debug
     prints, i prefer that we use a macro, something like this:

     eee_dbg(%s: receive relay packet: len =3D %d\n", __FUNCTION__,
skb->len);

     that gets defined to null if EEE_DEBUG isn't defined.  that reduces
     the amount of ifdefs in the code.

ok


