X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7C4E3.DB787571@onstor-exch02.onstor.net>; Thu, 12 Jul 2007 16:22:12 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Thu, 12 Jul 2007 16:22:11 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0485C837@onstor-exch02.onstor.net>
In-Reply-To: <20070712162639.05cf17fc@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcfE3BlANe6rosFhQFu3bF6dOkBCXwAB7+iw
References: <BB375AF679D4A34E9CA8DFA650E2B04E0485C771@onstor-exch02.onstor.net> <20070712162639.05cf17fc@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

ok

>-----Original Message-----
>From: Andy Sharp
>Sent: Thursday, July 12, 2007 4:27 PM
>To: Maxim Kozlovsky
>Subject: Re: Please review
>
>On Thu, 12 Jul 2007 15:39:25 -0700 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>> Change 24551 by maximk@maximk-5 on 2007/07/12 15:34:05 *pending*
>>
>>
>>         Use static memory map for the marvell memory to avoid
>> dependency on the
>>         order of initialization.
>>
>>            Do not change the FC channel settings in the linux serial
>> driver.
>>
>>            Remove useless calls to add-wired-entry() in setup.c.  The
>> mappings get
>>            reinitialized in trap-init(), and we don't really want to
>> do this anyway.
>>
>>            Add the handler for the FC messaging interrupt.
>>
>>            Reviewed by andys.
>>
>> Affected files ...
>>
>> ...
>>
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/setup
>> .c#2 edit
>> ...
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/net/natsemi.c#2
>> edit
>> ...
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/serial/mpsc.c#3
>> edit
>> ...
>>
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus
>> .c#2 edit
>> ...
>>
//depot/cougar/linux/kernel/linux-mips-2.6/include/asm-mips/mach-bobcat/
>> bobcat.h#2 edit
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/setup.c
>
>     no and no.  and wired entries don't get wiped out by
>     trap_init/tlb_init, read the code again.
>
>linux/kernel/linux-mips-2.6/drivers/net/natsemi.c
>
>     this seems to be the wrong place to make modifications
>
>linux/kernel/linux-mips-2.6/drivers/serial/mpsc.c
>
>     line 710
>     at least fix the spelling if you're going to change this line
>
>     line 689
>     changes are unexplained and would seem to be unnecessary therefore
>
>     line 876
>     these changes fall into the same category as the change for the
>     natsemi.c driver.  why remove a facility and replace it with
>     hardcoded numbers?  which I won't get a look at until I get to
>     bobcat.h, i presume.
>
>linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c
>
>     line 171
>     why don't you make these changes in bobcat_bm_fpga.h?
>     and why don't you use the macros therein?
>
>     line 796
>     NOT
>
>     this whole function needs going though, things like line 846 look
>     wrong to me (ioremap?), there's probably a lot more.
>
>     line 879-883
>     why does this need to be here?  probably not necessary.
>
>     line 876
>     uh, please fix this, and the request_irq call above it.  use a
>     macro for the irq number and like that.  bobcat.h would be a good
>     place for that.
>
>linux/kernel/linux-mips-2.6/include/asm-mips/mach-bobcat/bobcat.h
>
>     line 93
>     so?  so have it start after the "ssc message pool", whatever that
>     is. these changes are completely unnecessary.
>
>     line 106
>     put your irq for management bus after this line ~:^)

