X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7BFF1.E92831BB@onstor-exch02.onstor.net>; Fri, 6 Jul 2007 09:20:12 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review
Date: Fri, 6 Jul 2007 09:20:11 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E046A87CA@onstor-exch02.onstor.net>
In-Reply-To: <20070705175356.5ff0f5df@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review
Thread-Index: Ace/aCHKHusGJqIAR7uJWCe1ZN2KMQAhlRaw
References: <20070705175356.5ff0f5df@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Arch/mips/kernel/traps.c:

1447: Does this work? I have tried the same change, and the kernel
stopped booting.

Ds1511.c:

23: Unsigned long, otherwise it will not work on 64bit.

295: long

301: // comment

416: long

Irq.c:=20

97: Is marvell really using both interrupt lines? Can you even connect
it like this? There must be a bmfpga interrupt on one of these lines.

Reset.c:=20

What's wrong with using include file?=20

Setup.c:

417: Let's postpone these changes, you have not done the corresponding
FC changes. This is not required currently.

Ide-cs.c:

219: I don't get this while (1). It looks like it only terminates in
success case.

Quirks.c:

Whitespace change only, why waste a revision on this.






-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, July 05, 2007 5:54 PM
To: Maxim Kozlovsky
Subject: please review

changelist 24453
client ripper
branch cougar

all files are under .git are binary or contain only a SHA-1 hash, so
don't worry about them.

Change 24453 by andys@ripper on 2007/07/05 11:42:39 *pending*

        Checkpoint checkin of Linux kernel changes including RM9k
        errata WAR includes.  Which hopefully help with the SIGILL
	issues we are having.
       =20
        Fixes to pd6729 pcmcia bridge driver.
        PCI mods and touch-ups.
        Platform code updates.
	Fix compile errors and warnings in ds1511.c, pd6729.c, mem.c

Affected files ...

... //depot/cougar/linux/kernel/linux-mips-2.6/.config#2 delete
... //depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/Kconfig#1 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/kernel/traps.c#1
edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/ds151
1.c#1 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/ds151
1.h#1 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/irq.c
#1 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/platf
orm.c#1 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/prom.
c#2 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/reset
.c#1 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/setup
.c#1 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-bobcat.c#
1 edit
... //depot/cougar/linux/kernel/linux-mips-2.6/bobcat-config#2 edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/mem.c#2 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/ide/legacy/ide-cs.c#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/net/natsemi.c#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/pci/quirks.c#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/pcmcia/Kconfig#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/pcmcia/cirrus.h#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/pcmcia/cistpl.c#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/pcmcia/cs.c#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/pcmcia/pd6729.c#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/pcmcia/pd6729.h#1
edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/pcmcia/rsrc_nonstatic
.c#1 edit
... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/serial/mpsc.c#1
edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/include/asm-mips/mach-bobcat/
bobcat.h#1 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/include/asm-mips/mach-bobcat/
spaces.h#1 edit
... //depot/cougar/linux/kernel/linux-mips-2.6/include/asm-mips/war.h#1
edit
... //depot/cougar/linux/kernel/linux-mips-2.6/.git/FETCH_HEAD#1 add
... //depot/cougar/linux/kernel/linux-mips-2.6/.git/ORIG_HEAD#1 add
... //depot/cougar/linux/kernel/linux-mips-2.6/.git/index#2 edit
... //depot/cougar/linux/kernel/linux-mips-2.6/.git/FETCH_HEAD#1 add
... //depot/cougar/linux/kernel/linux-mips-2.6/.git/ORIG_HEAD#1 add
... //depot/cougar/linux/kernel/linux-mips-2.6/.git/index#2 edit
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/02/1e7bf40ac7657
4e9b4b45160a107e19cc6aabf#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/02/bf40fb7ea1c30
4c501ad906e14b9d95ce9b0ed#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/09/b368ec35fb626
d60e52c5d74d482706008a2c4#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/11/b11ff25bbd1ac
946a19525e07635ed2797b856#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/18/7a9a951a2af92
2c4ec4352b2388a91100b81a3#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/19/a84934fbf258a
22749c1456a6d48611870e590#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/1f/1657cdb58b822
625ef93771921471b7a150ac6#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/20/aabadbab87d94
edcafaa970e3d0466015f5fcf#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/24/ebfe092f9fc34
b7b1e6f7736607d55d4a0bd6e#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/28/289c445d8cf73
d4ec0665819e97008444f60e5#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/29/58babb6177d76
d2be99e050edb886655bf4480#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/2a/b3121d651a782
04d303335fdb2bd45f2f0740d#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/2d/679499cdb07db
5e32f19412510b69ff42bac4c#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/2f/5d3c21bf5aa5a
3478bad140f87b53795c445b8#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/31/942fcc3f613d3
f76838139817d4802ec365e2b#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/33/8bc959a45728e
d7cdbe0304d56eaee79a5a699#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/39/94176f88d4640
a701d8af87726d57a2351d2af#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/3b/58cfe4d1eef93
70036acd01d5a429c8ced4292#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/43/a7dee77a2a204
520620e510d7c8742a719e7cb#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/44/8a95763c527ea
a8a35577508230c2dff7bf944#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/4a/9849aab4ba144
a3f30307f43c6ffc838443fde#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/52/28087de0bdbdd
35d45c2c5e8edbf52ebad0bde#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/57/4971e6c25b809
416f332d9591cefed0638801a#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/58/b673360c9f35f
5f68627247cf05ca822849658#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/5a/f381e786f27bd
25901f07452199a45a9b150d1#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/5b/d4ee53224ca1e
dd585d08a48abbb9bce59a429#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/5c/90be00e243418
2727d1610e9ee2c2e897ec369#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/5c/e130bc005c6f4
c125095ddad3f84d6bd14f91d#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/5d/f03207a750432
0d3741cf282a41ffe20f45e2c#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/60/77575932abbf8
ce17a92017e91c8224dad9045#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/64/f10fc74fac61e
c54179eb207959e495b2bb274#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/66/85f10d1548325
928bcab2c4ee3cd0a3501ab4a#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/67/cd019681ffe85
9c7e264511e25f4033a160112#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/68/04fc7d38b0002
56cf1ae5376b96b6a4c74cb01#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/6d/b974c568a34b1
d0ba27189a666b858795721b0#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/7d/40c1db9fd7ec6
f1af6feb0092a8f28c25c2b7f#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/7e/7a9b25d45ce75
bb3e00ab6485bd7234e88cb7c#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/88/f55c40a4fb2d1
c629dcde02f2695408c2c4594#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/8d/70dd530213545
593a6fb8a92a6ed30d0dd581a#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/8d/c0c342ccef3e5
7fcad95da789b769d8503e627#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/8e/fc7dc16d78c44
39e55f1a2d7fbf9ef967f3ed9#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/90/bdf4124529b3a
76c1215d82a954b60673504be#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/90/e2c22f1729e87
bac0a810539ad1c6b96b736f2#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/96/35b1bc4c32c21
1e8ae2b05bc7562fb5b35f4b1#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/9a/fefbea1e9a9e4
00011c56e3d58a1dcef4db880#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/9d/9881de46443bd
5d0f920f630e79978f95e921c#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/9e/4e4cce07d5264
0b61803d73c02730393bdaebb#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/a0/58311f295eaa2
ed6b0ee2c95c8f537a89a2e19#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/a9/cfd80d9828d30
93abf55e7a4c0f17f962ffc7a#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/ad/860ab328f66ca
03cfe9271cf4cc42a43f5147c#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/ae/c06ff4970d17b
396afd7e6b8074f209a020217#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/b2/09e9f92d741f0
c7bdd21b9f8ed029692ed92b3#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/b5/e0d594a962670
169563c0a8629863152549a8a#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/bb/a3bdc1dfd7b89
9ee2506ec46d9848d34a7f9e6#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/bc/604ebf6faa135
c724c174c439ff39175b2b03f#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/bd/4c2feb1fb5724
22c292b811be6c8bbccae5b7c#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/bf/293c5dc9c77b2
bb8325166dddfc70a645aab44#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/c0/9e8bb4b7d6481
81b97d9e623b634345414e417#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/c5/3be78262e214d
3046dff9d97e5ac3c75ec3c1a#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/c7/d1a9913ab0ac8
80ebc479cab2a1861110f3d3a#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/ca/5633bf4927d87
2cd53690d8a0ca0f8dd07083c#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/cd/e755a56cec910
6828736f77b04e11bc96b4ba5#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/d1/741ae4ca526c2
d00582c54dc44e87dc660c167#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/d3/e3f9284053d7b
dd28dbcf958165ed27a70c91c#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/df/b016b0ff5e1ef
b0cf4cabe75be84b44b3cb710#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/e3/ec305d9c0c410
5df1eb842c6f159234e1e6508#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/e8/9d4f82986d6f6
bf5b237d886ce378f478defa5#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/ea/4b774efcad130
41ec1c1fece099e871f3e1b2b#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/ee/73c5f76d48ed2
3ad3d87f11ae056e95b5f913e#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/f7/00c876333ca4e
336318c157515ac8dce4a1428#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/fc/adb6ad765ee5f
0758f80f9904f1079ae3ab564#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/fc/c499f92a0062a
d8eaf98559a15b8d409ddf40f#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/fc/e3220f93ba475
1b3ac2f9d49fa3b274a191962#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/objects/fd/2f659c0d1d0ec
95bc6b85baf858f2ef7e4226a#1 add
...
//depot/cougar/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-2.6.20
-stuper-hack#2 edit
