X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7C18A.31FC70E9@onstor-exch02.onstor.net>; Sun, 8 Jul 2007 10:02:49 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Sun, 8 Jul 2007 10:02:48 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E046A8A55@onstor-exch02.onstor.net>
In-Reply-To: <20070706134958.67521fc3@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcfADzgp4y29sGI1Smm+lcgzsrJPFABeigsg
References: <BB375AF679D4A34E9CA8DFA650E2B04E045C1535@onstor-exch02.onstor.net><20070705183902.078a1abc@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E046A88D2@onstor-exch02.onstor.net> <20070706134958.67521fc3@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I've fixed the comments and the caps.

>> >     line 151
>> >     why do you need the qualifiers?  virt-to-phys and phys-to-virt
>> >     should work fine no matter what.   i thought this was all done
>> with a
>> >     PCI driver anyway.  That's what you said when I asked you if
the
>> >     mgmt_bus driver used these shared memory areas.
>> [MK] Always using virt_to_phys/phys_to_virt does not work for some
>> reason, probably because what it is calling "phys address" is not
>> exactly a "phys address" for Linux.
>
>Maybe because it isn't mapping that memory that way.  You might be
>fiddling all over the place and not even know it.  These functions are
>stupidly simple, they don't do anything more than what you've got
>there.  They're supposed to "never" be used in drivers.  Of course,
>that's exactly what I use in the natsemi and mpsc drivers ~:^) What=20
>memory address range are you using it on?
[MK]=20

0x9a000000 phys, 0xba000000 virtual. It does not like 0x9a000000. I am
not mapping anything, just using the kseg1. The physical mapping is
already there.


>> >
>> >linux/kernel/linux-mips-2.6/net/neteee/neteee.c
>> >
>> >     line 47
>> >     hmm, just trying to mess with the c-preprocessor?
>> >
>> >     line 746
>> >     since you're just copying the data into and outa skb's, why not
>> use
>> >     uncached addresses exclusively for share memory regions?
unless
>> >     there are some places where we just add a pointer into a
>> structure,
>> >     but that is dangerous so i hope we aren't doing that.
>> [MK] Huh?
>
>which word didn't you understand?  we don't need cache routines if you
>use uncached addresses.  ja-know what i mean?
[MK]=20

The copy from uncached memory is slower.=20

