X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7B904.BF7AC940@onstor-exch02.onstor.net>; Wed, 27 Jun 2007 13:47:24 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Wed, 27 Jun 2007 13:47:24 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0451DB0D@onstor-exch02.onstor.net>
In-Reply-To: <20070627142616.06e462bf@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: Ace5AcvVzyX2BjshSBSDvHQDyOQOOwAAJ84w
References: <BB375AF679D4A34E9CA8DFA650E2B04E0451D5F1@onstor-exch02.onstor.net> <20070627142616.06e462bf@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>


linux/kernel/linux-mips-2.6/include/net/neteee/eee.h

     line 3 (removal of nfx-types.h include)
     uh, say what? no, no, no, no, no, let's discuss
     thinking about it more, is this even the right name for this file?
     should there be a nfxeee.h kernel/userspace include file for eee
     definitions?  or is this nfx-types.h file something else
altogether?
MK> There were no definitions used from this file.

     line 60-61
     this is completely broken, what is this?  a richard-ism, i presume?
MK> Removed unused bsdism.

     line 77
     yeah, these prototypes probably don't belong in here.  or do they?
MK> They don't. R copied them from bsd code for no reason.

linux/kernel/linux-mips-2.6/net/Makefile

     looks good


linux/kernel/linux-mips-2.6/net/neteee/neteee.c

     line 63
     uh, not what i had in mind.  there's no "dragging" of header files.
     the combined kernel/userspace header file(s) need to be defined and
     coded, and the makefiles will take care of the rest at build time.
     So, all you have to do is the coding and defining part.  someone
else
     will finish the makefile part.  someone else named larry.  after i
     teach him what is needed, which isn't much.

MK> These constants are not used anywhere in the user code. They are
used only in EEE code, which is compiled with its own set of include
files and different compiler. This means that either the linux
compilation has to reference the nfx-tree directory, or the nfx-tree
compilation has to reference the linux directory, or they both must
reference some other directory. I personally don't really care either
way, since you have some ideas on what to do with the include files it
would be great if you will just make a decision and we stop going in
circles arguing about it.

     line 977, 1050
     change to #ifdef DEBUG or similar equivalent
     actually, a module paramenter for debug level would be a good thing
     for this.
MK> Changed ifdef.=20

nfx-tree/code/sm-anpssc/Makefile

     line 48
     what is this?  either we need this file or we don't.
     i must be missing something.
MK> I have no idea, copied from some other makefile.

     line 56
     excellent

nfx-tree/code/sm-anpssc/anpssctest.c

     >>add nfx-tree/code/sm-anpssc/anpssctest.c

     fix the trailing whitespace in places.

     nice.  where did this come from?  did we have it before or did you
     write it "just now"?
MK> OK. Just now.

